Decide how to enable/disable unit conversions in flavors
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Smalyshev
	Sep 5 2016, 8:26 PM

Description

Right now once T117031 is implemented if unit conversion is configured it is automatically used. We may want to have more fine-grained configuration, i.e. some option for disabling/enabling it, accounting for PRODUCE_NORMALIZED_VALUES and maybe other configuration values.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use flavor flags to configure builder	mediawiki/extensions/Wikibase	master	+68 -108

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T88728 Improve Wikimedia dumping infrastructure
Open		None	T88991 improve Wikidata dumps [tracking]
Open		None	T46581 Partial Wikidata dumps
Resolved		Smalyshev	T46580 Script for creating RDF dumps of all entities
Duplicate		None	T211495 Dump(s) of Wikidata classes
Duplicate		None	T211497 Dump(s) of Wikidata instances of Q5
Open		None	T162351 Create a "page prop" RDF dump for Wikidata entities ("pagePropertiesRdf")
Open		None	T98320 [Task] Create dump of entity redirects (JSON or n-triples)
Invalid		None	T285307 Create randomly split partial entity dumps
Resolved		Lydia_Pintscher	T44063 [Epic] Provide a plain linked data interface for accessing entities
Resolved		hoo	T101837 [Story] switch default rdf format to full (include statements)
Open		None	T50143 Implement complete RDF mapping for entities (tracking)
Open		None	T56318 Quantity datatype (tracking)
Resolved	Feature	Michael	T68580 Better support for exact values in Quantity DataType
Resolved		daniel	T140997 When guessing quantity precision from digits, use the +/-0.5 rule rather than the +/-1 rule
Open		None	T133042 Quantity datatype precision (tracking)
Resolved		Lydia_Pintscher	T115269 [Story] When a Quantity is entered with no uncertainty/bounds given, do not guess uncertainty/bounds until needed.
Resolved		thiemowmde	T115270 Allow QuantityValue objects to have empty/no bounds set
Resolved		daniel	T105623 [Task] Investigate quantification of quantity precision (+/- 1 or +/- 0.5)
Open		None	T77977 [Epic] Unit support
Stalled		None	T111770 [Story] Decide how to represent quantities with units in the "truthy" RDF mapping
Stalled		None	T115934 Represent simple values with units in RDF
Resolved		Smalyshev	T117031 Represent normalized unit values in full values RDF
Open		None	T145424 Represent normalized unit values in simple values RDF
Open		None	T77978 [Story] Support unit conversion
Resolved		Smalyshev	T117032 Create configuration for specifying units conversions
Resolved		Smalyshev	T145426 Provide a way to add new unit normalizations to the query service without a full reload
Resolved		Smalyshev	T144768 Decide how to enable/disable unit conversions in flavors
Invalid		None	T150656 Light-year and gigaparsec do not show up in the query for the longest things on Wikidata.
Resolved		daniel	T150877 Unit conversion does not create psn:P2043 for Q531
Resolved		Smalyshev	T150881 add support for additional dimensions for unit conversion
Open		None	T234809 Support normalized quantities in Lua
Resolved		Lydia_Pintscher	T142086 [Task] announce quantity changes
Resolved		Ladsgroup	T142087 [Task] prepare bot for quantity change fixes
Open		None	T112247 [RFC] Create a "number" datatype for exact values
Resolved		Ladsgroup	T154168 Quantity changes broke ORES

Event Timeline

Smalyshev created this task.Sep 5 2016, 8:26 PM

We probably need to configure rdf-builder-factory-callback for VT:quantity somehow depending on flavor flags. The problem is flavor flags are not accessible there and not passed to ValueSnakRdfBuilderFactory either, so we'd have to either add parameter or maybe modify $mode parameter to be more complex.

@daniel, any ideas on how to make it best?

Jc3s5h subscribed.Sep 5 2016, 8:58 PM

@Smalyshev maybe we can just pass the GENERATE_XXX flags as $mode, what do you think? The flags should cover the current information in $mode anyway.

Yes, this should be possible, though requires changing all code that uses $mode, but it's not too much right now. I'll look into it later.

Smalyshev renamed this task from Decide how to configure unit conversions to Decide how to enable/disable unit conversions in flavors.Sep 6 2016, 4:59 PM

Smalyshev added a parent task: T77978: [Story] Support unit conversion.

Smalyshev claimed this task.Sep 6 2016, 6:13 PM

Change 309227 had a related patch set uploaded (by Smalyshev):
Use flavor flags to configure builder

https://gerrit.wikimedia.org/r/309227

gerritbot added a project: Patch-For-Review.Sep 8 2016, 2:24 AM

Smalyshev moved this task from Incoming to Current work on the Wikidata-Query-Service board.Sep 9 2016, 1:11 AM

Smalyshev added a project: Discovery-Wikidata-Query-Service-Sprint.

Change 309227 merged by jenkins-bot:
Use flavor flags to configure builder

https://gerrit.wikimedia.org/r/309227

Smalyshev closed this task as Resolved.Sep 12 2016, 3:46 PM

Smalyshev moved this task from Backlog to Done on the Discovery-Wikidata-Query-Service-Sprint board.

daniel added a parent task: T145424: Represent normalized unit values in simple values RDF.Sep 12 2016, 5:27 PM