Page MenuHomePhabricator

Don't pollute history with map hashes
Closed, ResolvedPublic

Description

We should use history.replaceState() when setting the map hash to avoid filling history with more entries on every drag/zoom and making the back button less useful.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Will be fixable once T135692, the day I figure out how to work with https://phabricator.wikimedia.org/diffusion/GOJR/ & Arcanist.

Yurik triaged this task as High priority.Sep 14 2016, 8:37 PM
Yurik moved this task from Backlog to To-do on the Maps-Sprint board.

yes please that is a very annoying feature

@JGirault can we simply not update URL until we figure out how to do "replace" ?

Change 318425 had a related patch set uploaded (by JGirault):
Disable hash update temporarily, to avoid polluting browser history

https://gerrit.wikimedia.org/r/318425

Change 318425 merged by jenkins-bot:
Disable hash update temporarily, to avoid polluting browser history

https://gerrit.wikimedia.org/r/318425

Change 318457 had a related patch set uploaded (by Yurik):
Disable hash update temporarily, to avoid polluting browser history

https://gerrit.wikimedia.org/r/318457

Change 318457 merged by jenkins-bot:
Disable hash update temporarily, to avoid polluting browser history

https://gerrit.wikimedia.org/r/318457

The problem has been temporarily resolved, but we should re-enable dynamic hash update once url replace is done in core.