Page MenuHomePhabricator
Create Task
Maniphest T144880

Don't pollute history with map hashes
Closed, ResolvedPublic
Actions

Description

We should use history.replaceState() when setting the map hash to avoid filling history with more entries on every drag/zoom and making the back button less useful.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Kartographermaster+0 -43Remove dead code from fullscreen map code
mediawiki/extensions/Kartographerwmf/1.28.0-wmf.23+0 -4Disable hash update temporarily, to avoid polluting browser history
mediawiki/extensions/Kartographermaster+0 -4Disable hash update temporarily, to avoid polluting browser history
Customize query in gerrit

Related Objects
Search...

Event Timeline

MaxSem created this task.Sep 7 2016, 12:36 AM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptSep 7 2016, 12:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• JGirault added a subscriber: • JGirault.Sep 7 2016, 10:03 AM

Will be fixable once T135692, the day I figure out how to work with https://phabricator.wikimedia.org/diffusion/GOJR/ & Arcanist.

Yurik moved this task from Unsorted to UI tasks on the Maps (Kartographer) board.Sep 9 2016, 2:56 AM
Yurik triaged this task as High priority.Sep 14 2016, 8:37 PM
Yurik moved this task from Backlog to To-do on the Maps-Sprint board.
MaxSem moved this task from All map-related tasks to Kartographer on the Maps board.Sep 23 2016, 7:14 AM
• JGirault claimed this task.Oct 21 2016, 12:13 AM
Jarekt added a subscriber: Jarekt.Oct 27 2016, 3:30 AM

yes please that is a very annoying feature

Yurik added a subscriber: Yurik.Oct 27 2016, 3:38 AM

@JGirault can we simply not update URL until we figure out how to do "replace" ?

• JGirault added a comment.Oct 27 2016, 9:17 PM

@Yurik that's very simple

• JGirault mentioned this in T149368: Update map hash without polluting browser history.Oct 27 2016, 9:21 PM
• JGirault added a parent task: T149368: Update map hash without polluting browser history.
gerritbot added a subscriber: gerritbot.Oct 27 2016, 9:23 PM

Change 318425 had a related patch set uploaded (by JGirault):
Disable hash update temporarily, to avoid polluting browser history

https://gerrit.wikimedia.org/r/318425

gerritbot added a project: Patch-For-Review.Oct 27 2016, 9:23 PM
• JGirault moved this task from To-do to Needs review on the Maps-Sprint board.Oct 27 2016, 9:23 PM
gerritbot added a comment.Oct 27 2016, 10:51 PM

Change 318425 merged by jenkins-bot:
Disable hash update temporarily, to avoid polluting browser history

https://gerrit.wikimedia.org/r/318425

gerritbot added a comment.Oct 27 2016, 10:58 PM

Change 318457 had a related patch set uploaded (by Yurik):
Disable hash update temporarily, to avoid polluting browser history

https://gerrit.wikimedia.org/r/318457

gerritbot added a comment.Oct 27 2016, 11:24 PM

Change 318457 merged by jenkins-bot:
Disable hash update temporarily, to avoid polluting browser history

https://gerrit.wikimedia.org/r/318457

Yurik closed this task as Resolved.Oct 27 2016, 11:41 PM

The problem has been temporarily resolved, but we should re-enable dynamic hash update once url replace is done in core.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 4:00 PM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)).Nov 2 2016, 5:00 PM
Deskana moved this task from Needs review to Done on the Maps-Sprint board.Apr 19 2017, 4:29 PM
gerritbot added a comment.Aug 17 2022, 1:24 PM

Change 824206 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Remove dead code from fullscreen map code

https://gerrit.wikimedia.org/r/824206

gerritbot removed a project: Maps (Kartographer).Aug 17 2022, 1:24 PM
gerritbot added a comment.Oct 22 2022, 10:01 AM

Change 824206 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove dead code from fullscreen map code

https://gerrit.wikimedia.org/r/824206

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 22 2022, 11:00 AM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL