Page MenuHomePhabricator

wdqs-updater tries to apply updates from non-Entity pages, fails
Closed, ResolvedPublic

Description

It tries to run the following query, but that fails with a syntax error (line 4, column 1230, <https://www.wikidata.org/wiki/Wikidata:Wiki Loves Open Data>).

SELECT DISTINCT ?entity ?s
    WHERE {
    VALUES ?entity {
    <http://www.wikidata.org/entity/Q19906543> <http://www.wikidata.org/entity/Q19276997> <http://www.wikidata.org/entity/Q3012585> <http://www.wikidata.org/entity/Q8279692> <http://www.wikidata.org/entity/Q1387526> <http://www.wikidata.org/entity/Q2074898> <http://www.wikidata.org/entity/Q19275572> <http://www.wikidata.org/entity/Q3037134> <http://www.wikidata.org/entity/Flow> <http://www.wikidata.org/entity/Q19276229> <http://www.wikidata.org/entity/Q19259864> <http://www.wikidata.org/entity/Q1394849> <http://www.wikidata.org/entity/Q19277195> <http://www.wikidata.org/entity/Q583278> <http://www.wikidata.org/entity/Q19274812> <http://www.wikidata.org/entity/Q20354069> <http://www.wikidata.org/entity/Q543184> <http://www.wikidata.org/entity/Q19906555> <http://www.wikidata.org/entity/Q2440051> <http://www.wikidata.org/entity/Q130607> <http://www.wikidata.org/entity/Q24068717> <http://www.wikidata.org/entity/Q19275795> <http://www.wikidata.org/entity/Q19910050> <http://www.wikidata.org/entity/Q8078234> <http://www.wikidata.org/entity/Q19906382> <http://www.wikidata.org/entity/Q1113849> <http://www.wikidata.org/entity/Q3060044> <http://www.wikidata.org/entity/Q19277040> <http://www.wikidata.org/entity/Q767016> <http://www.wikidata.org/entity/Wiki Loves Open Data> <http://www.wikidata.org/entity/Q26284406> <http://www.wikidata.org/entity/Q19909624> <http://www.wikidata.org/entity/Q4977852> <http://www.wikidata.org/entity/Q19907794> <http://www.wikidata.org/entity/Q502822> <http://www.wikidata.org/entity/Q19274592> <http://www.wikidata.org/entity/Q634853> <http://www.wikidata.org/entity/Q645261> <http://www.wikidata.org/entity/Q18577193> <http://www.wikidata.org/entity/Q12048> <http://www.wikidata.org/entity/Q26197794> <http://www.wikidata.org/entity/Q672224> <http://www.wikidata.org/entity/Q1823717> <http://www.wikidata.org/entity/Q4977814> <http://www.wikidata.org/entity/Q406488> <http://www.wikidata.org/entity/Q9081116> <http://www.wikidata.org/entity/Q20971496> <http://www.wikidata.org/entity/Q19259697> <http://
    www.wikidata.org/entity/Q539029> <http://www.wikidata.org/entity/Q23037> <http://www.wikidata.org/entity/Q53764> <http://www.wikidata.org/entity/Q19274795> <http://www.wikidata.org/entity/Q19906573> <http://www.wikidata.org/entity/Q19259836> <http://www.wikidata.org/entity/Q585620> <http://www.wikidata.org/entity/Q26828339> <http://www.wikidata.org/entity/Q775978> <http://www.wikidata.org/entity/Q26828336> <http://www.wikidata.org/entity/Q1014598> <http://www.wikidata.org/entity/Q3396366> <http://www.wikidata.org/entity/Q19274921> <http://www.wikidata.org/entity/Q17730594> <http://www.wikidata.org/entity/Q26828344> <http://www.wikidata.org/entity/Q759412> <http://www.wikidata.org/entity/Q5182233> <http://www.wikidata.org/entity/Q22056464>
    }
    ?entity ?statementPred ?statement .
    FILTER( STRSTARTS(STR(?statement), "http://www.wikidata.org/entity/statement/") ) .
    { ?statement <http://www.w3.org/ns/prov#wasDerivedFrom> ?ref .
    ?ref ?expandedValuePred ?s .
    } UNION {
    ?statement ?somePred ?s .
    }
    FILTER( STRSTARTS(STR(?s), "http://www.wikidata.org/value/") ) .
    }

Apparently we're picking up changes of non-Entity pages here.

Details

Related Gerrit Patches:
wikidata/query/rdf : masterValidate incoming IDs

Related Objects

Event Timeline

hoo created this task.Sep 7 2016, 12:47 PM
Restricted Application added projects: Wikidata, Discovery. · View Herald TranscriptSep 7 2016, 12:47 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes, Aklapper. · View Herald Transcript
hoo updated the task description. (Show Details)
hoo added a subscriber: Gehel.
Smalyshev claimed this task.Sep 7 2016, 3:37 PM

Mentioned in SAL [2016-09-07T15:59:34Z] <gehel> deploying wdqs, fix for T144913

Change 309034 had a related patch set uploaded (by Smalyshev):
Validate incoming IDs

https://gerrit.wikimedia.org/r/309034

Change 309034 merged by jenkins-bot:
Validate incoming IDs

https://gerrit.wikimedia.org/r/309034

Mentioned in SAL [2016-09-07T18:37:00Z] <gehel> deploying wdqs, fix for T144913

Smalyshev closed this task as Resolved.Sep 7 2016, 6:53 PM

Should be fine now.

The question still stays how comes we got "Wiki Loves Open Data" in NS_MAIN namespace without being an entity and how it got into the RC log...