Page MenuHomePhabricator

[regression-betalabs] When 'Enhanced recent changes' option is used, Special:Watchlist displays Error page with 'Revision not found in revisionCache' for periods of time >3 days
Closed, ResolvedPublic

Description

Unfortunately, it's reproducible only for one user: Etonkovidova ( wl_user=4462 and #of watched items 1280) on enwiki betalabs:

  1. User :Etonkovidova has 'Enhanced recent changes' enabled - making collapsible sections in Watchlist and Recent changes.
  1. On the Watchlist, hide 'probably good edits' nd change the time persiod to display to 7 days:

https://en.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?days=7&hidenondamaging=1&namespace=&action=submit
Note that ORES does not display highlighting, only 'r':

Screen Shot 2016-09-12 at 3.47.50 PM.png (576×1 px, 166 KB)

  1. Uncheck " hide 'probably good edits' " - the following error is displayed:
An error has occurred.

Return to Main Page

[V9cxCApEEaoAAGcSUioAAAAK] /wiki/Special:Watchlist?days=30&namespace=&action=submit Flow\Exception\FlowException from line 155 of /srv/mediawiki/php-master/extensions/Flow/includes/Formatter/ChangesListQuery.php: Revision not found in revisionCache: tb59pbm28a2uxl3s

Backtrace:

#0 /srv/mediawiki/php-master/extensions/Flow/Hooks.php(525): Flow\Formatter\ChangesListQuery->getResult(EnhancedChangesList, RCCacheEntry, boolean)
#1 /srv/mediawiki/php-master/extensions/Flow/Hooks.php(509): FlowHooks::onEnhancedChangesListModifyBlockLineData(EnhancedChangesList, array, RCCacheEntry)
#2 /srv/mediawiki/php-master/includes/Hooks.php(195): FlowHooks::onEnhancedChangesListModifyLineData(EnhancedChangesList, array, array, RCCacheEntry, array)
#3 /srv/mediawiki/php-master/includes/changes/EnhancedChangesList.php(445): Hooks::run(string, array)
#4 /srv/mediawiki/php-master/includes/changes/EnhancedChangesList.php(262): EnhancedChangesList->getLineData(array, RCCacheEntry, array)
#5 /srv/mediawiki/php-master/includes/changes/EnhancedChangesList.php(742): EnhancedChangesList->recentChangesBlockGroup(array)
#6 /srv/mediawiki/php-master/includes/changes/EnhancedChangesList.php(105): EnhancedChangesList->recentChangesBlock()
#7 /srv/mediawiki/php-master/includes/specials/SpecialWatchlist.php(404): EnhancedChangesList->recentChangesLine(RecentChange, NULL, integer)
#8 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(358): SpecialWatchlist->outputChangesList(ResultWrapper, FormOptions)
#9 /srv/mediawiki/php-master/includes/specialpage/ChangesListSpecialPage.php(77): ChangesListSpecialPage->webOutput(ResultWrapper, FormOptions)
#10 /srv/mediawiki/php-master/includes/specials/SpecialWatchlist.php(88): ChangesListSpecialPage->execute(NULL)
#11 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(522): SpecialWatchlist->execute(NULL)
#12 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(583): SpecialPage->run(NULL)
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(283): SpecialPageFactory::executePath(Title, RequestContext)
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(750): MediaWiki->performRequest()
#15 /srv/mediawiki/php-master/includes/MediaWiki.php(521): MediaWiki->main()
#16 /srv/mediawiki/php-master/index.php(43): MediaWiki->run()
#17 /srv/mediawiki/w/index.php(3): include(string)
#18 {main}

Note: For '3 days' setting, no error page will be displayed.

Event Timeline

@Mattflaschen-WMF betalabs enwiki - I added it to the issue description.

Re-checked in betalabs - 1.28.0-alpha (4cbefc1). The Watchlist for User:Etonkovidova is displayed without errors.

Etonkovidova renamed this task from [regression-betalabs] Special:Watchlist displays Error page with 'Revision not found in revisionCache' to [regression-betalabs] When 'Enhanced recent changes' option is used, Special:Watchlist displays Error page with 'Revision not found in revisionCache' for periods of time >3 days .Sep 12 2016, 11:18 PM
Etonkovidova reopened this task as Open.
Etonkovidova updated the task description. (Show Details)

Change 310961 had a related patch set uploaded (by Sbisson):
Don't crash when a revision is not found

https://gerrit.wikimedia.org/r/310961

Change 310961 merged by jenkins-bot:
Don't crash when a revision is not found

https://gerrit.wikimedia.org/r/310961