Page MenuHomePhabricator

Echo breaking MobileFrontend unit tests / causing fatals
Closed, ResolvedPublic

Description

MobileFrontend cannot merge any patches at current time due to browser test/phpunit failures due an issue in the Echo extension.

The error is:
Call to undefined hook MWEchoNotifUser::getGlobalMaxSeenTime

This might be a good time to add MobileFrontend to Echo's dependencies to avoid breakages like this.

This is causing fatals for logged in users on the beta cluster.
e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page

See:
https://integration.wikimedia.org/ci/job/mwext-mw-selenium/9875/artifact/log/Menus%20open%20correct%20page%20for%20anonymous%20users%3A%20Check%20links%20in%20menu.mp4

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 8 2016, 10:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson triaged this task as Unbreak Now! priority.Sep 8 2016, 10:39 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptSep 8 2016, 10:39 PM
Jdlrobson renamed this task from Echo breaking MobileFrontend unit tests to Echo breaking MobileFrontend unit tests / causing fatals.Sep 8 2016, 10:41 PM
Jdlrobson updated the task description. (Show Details)Sep 8 2016, 10:46 PM

I can't replicate this locally only on beta cluster. Might be config/user specific?

Change 309474 had a related patch set uploaded (by Catrope):
Follow-up 00e0b9f45d8: fix typo in method name

https://gerrit.wikimedia.org/r/309474

Sorry, this was because we only just merged a patch in Echo that had a typo in a method name.

Change 309474 merged by jenkins-bot:
Follow-up 00e0b9f45d8: fix typo in method name

https://gerrit.wikimedia.org/r/309474

phuedx closed this task as Resolved.Sep 9 2016, 8:46 AM
phuedx added a subscriber: phuedx.

Thanks for picking this up so quickly @Catrope/@Mattflaschen-WMF.