Page MenuHomePhabricator
Create Task
Maniphest T145163

Slim down the "alerts" icon pack to the bare essentials
Closed, ResolvedPublic
Actions

Description

Currently it has a bunch of stuff we don't use and probably never will, hence T139779: Kill badgeicons.json and use OOUI's icons-alerts.json instead exists. :-(

Details

ProjectBranchLines +/-Subject
oojs/uimaster+0 -28[BREAKING CHANGE] icons: Remove 'bellOn', deprecated in v0.25.0
oojs/uiv0.24.4+6 -3[DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be removed
oojs/uimaster+6 -3[DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be removed
oojs/uimaster+0 -10[BREAKING CHANGE] icons: Remove 'signature' icon, deprecated in v0.23.0
oojs/uimaster+0 -16[BREAKING CHANGE] icons: Remove 'eye'/'eyeClosed' icons, deprecated in v0.23.0
oojs/uimaster+13 -3[DEPRECATING CHANGE] icons: Move 'signature' to 'editing-advanced'
oojs/uimaster+89 -8[DEPRECATING CHANGE] icons: Move 'eye'/'eyeClosed' to 'accessibility'
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Sep 9 2016, 12:55 AM
Jdforrester-WMF added a subtask: T141801: WikimediaUI (Codex/OOUI) icon inventory (tracking).
Volker_E added subscribers: RHo, Esanders, Prtksxna and 2 others.Jun 27 2017, 9:29 AM

Things to make and do:

  • “Signature“ to be moved to 'editing-core' pack?
  • Putting everything besides “Alerts” & “Notices” (which isn't even used as Notices) into another pack, f.e. “Notifications“. Doesn't seem to make much sense, just reasoning about making it smaller by dividing for different use cases VE/Notifications
  • (Re-)moving “Eye”/“EyeClosed” icons out of pack (prob to accessibility). @Prtksxna Are there any detailed plans on using those in FileAnnotations still?

CC: @Esanders @Jdforrester-WMF on first two bullets and other ideas? @RHo @Pginer-WMF for looping in.

Prtksxna added a comment.Jun 27 2017, 9:52 AM
In T145163#3381575, @Volker_E wrote:
  • (Re-)moving “Eye”/“EyeClosed” icons out of pack (prob to accessibility). @Prtksxna Are there any detailed plans on using those in FileAnnotations still?

Nope. We could move or remove it.

gerritbot added a subscriber: gerritbot.Aug 25 2017, 10:06 PM

Change 373973 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE] icons: Move 'eye'/'eyeClosed' to 'accessibility'

https://gerrit.wikimedia.org/r/373973

gerritbot added a project: Patch-For-Review.Aug 25 2017, 10:06 PM
gerritbot added a comment.Aug 25 2017, 11:38 PM

Change 373988 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE] icons: Move 'signature' to 'editing-core'

https://gerrit.wikimedia.org/r/373988

gerritbot added a comment.Sep 5 2017, 4:05 PM

Change 373973 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] icons: Move 'eye'/'eyeClosed' to 'accessibility'

https://gerrit.wikimedia.org/r/373973

gerritbot added a comment.Sep 5 2017, 6:49 PM

Change 373988 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] icons: Move 'signature' to 'editing-advanced'

https://gerrit.wikimedia.org/r/373988

Volker_E updated the task description. (Show Details)Sep 6 2017, 5:29 PM
gerritbot added a comment.Sep 6 2017, 6:52 PM

Change 376328 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [BREAKING CHANGE] icons: Remove 'signature' icon, deprecated in v0.23.0

https://gerrit.wikimedia.org/r/376328

gerritbot added a comment.Sep 6 2017, 7:02 PM

Change 376330 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [BREAKING CHANGE] icons: Remove 'eye'/'eyeClosed' icons, deprecated in v0.23.0

https://gerrit.wikimedia.org/r/376330

Volker_E updated the task description. (Show Details)Sep 6 2017, 7:04 PM
gerritbot added a comment.Oct 13 2017, 5:14 PM

Change 376330 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] icons: Remove 'eye'/'eyeClosed' icons, deprecated in v0.23.0

https://gerrit.wikimedia.org/r/376330

gerritbot added a comment.Oct 13 2017, 5:33 PM

Change 376328 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] icons: Remove 'signature' icon, deprecated in v0.23.0

https://gerrit.wikimedia.org/r/376328

Jdforrester-WMF removed a project: Patch-For-Review.Oct 13 2017, 7:38 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a comment.Oct 13 2017, 7:46 PM

OK, now the icon pack is probably good to go – it has:

  • alert
  • bell
  • bellOn
  • comment
  • message
  • notice
  • speechBubble
  • speechBubbleAdd
  • speechBubbles
  • tray

Though only two of these are used on every page paint, most of the rest are used within the notification pull-out.

Volker_E added subscribers: Mooeypoo, Catrope.Oct 13 2017, 7:52 PM

From here on that should get feedback from Collaboration team, @Catrope @Mooeypoo?

Volker_E mentioned this in T139779: Kill badgeicons.json and use OOUI's icons-alerts.json instead.Dec 5 2017, 2:31 AM
Volker_E added a comment.EditedDec 5 2017, 2:33 AM

In the very last breath of this task I've stumbled upon that we're currently not using 'bellOn' either. :}
Have involved Design team to clarify if we want to continue or remove it from OOUI icons… Answer pending.

Volker_E added a comment.Dec 6 2017, 12:45 AM

Citing from conversation aside of Phab with @Pginer-WMF:

The active version of the bell is not used. I think it was planned for the mobile web, but never used or replaced by the current circle.

In general I'm in favour of our icon repo to represent a wider visual vocabulary beyond the icons we use in our products right now, as long as they can be useful in our ecosystem. But the "bellOn" seems too specific, and the potential use cases can be resolved with the regular bell instead. So I'm ok in removing it.

Volker_E updated the task description. (Show Details)Dec 6 2017, 12:47 AM
Volker_E removed a subscriber: gerritbot.
gerritbot added a comment.Dec 6 2017, 12:56 AM

Change 395684 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be removed

https://gerrit.wikimedia.org/r/395684

gerritbot added a project: Patch-For-Review.Dec 6 2017, 12:56 AM
Volker_E mentioned this in T141801: WikimediaUI (Codex/OOUI) icon inventory (tracking).Dec 6 2017, 1:00 AM
Volker_E mentioned this in M229: Refined WikimediaUI icons proposal.Dec 6 2017, 1:17 AM
gerritbot added a comment.Dec 11 2017, 9:45 PM

Change 395684 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be removed

https://gerrit.wikimedia.org/r/395684

gerritbot added a comment.Dec 20 2017, 9:14 PM

Change 399469 had a related patch set uploaded (by Bartosz Dziewoński; owner: VolkerE):
[oojs/ui@v0.24.4] [DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be removed

https://gerrit.wikimedia.org/r/399469

matmarex mentioned this in T183195: Release OOUI v0.24.4 with some backported patches.Dec 20 2017, 9:15 PM
gerritbot added a comment.Dec 20 2017, 9:25 PM

Change 399469 merged by jenkins-bot:
[oojs/ui@v0.24.4] [DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be removed

https://gerrit.wikimedia.org/r/399469

Volker_E removed a parent task: T139779: Kill badgeicons.json and use OOUI's icons-alerts.json instead.Dec 22 2017, 9:26 PM
Volker_E removed a subtask: T141801: WikimediaUI (Codex/OOUI) icon inventory (tracking).
Volker_E added a parent task: T139779: Kill badgeicons.json and use OOUI's icons-alerts.json instead.
Volker_E added a parent task: T141801: WikimediaUI (Codex/OOUI) icon inventory (tracking).Dec 22 2017, 9:28 PM
Liuxinyu970226 added a subscriber: Liuxinyu970226.Dec 23 2017, 4:25 AM
Jdforrester-WMF assigned this task to Volker_E.Jan 29 2018, 5:42 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Jan 29 2018, 5:46 PM

Change 406610 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] [BREAKING CHANGE] icons: Remove 'bellOn', deprecated in v0.25.0

https://gerrit.wikimedia.org/r/406610

Jdforrester-WMF updated the task description. (Show Details)Jan 29 2018, 5:47 PM
Jdforrester-WMF moved this task from Backlog to Waiting for breaking release on the OOUI board.
gerritbot added a comment.Mar 20 2018, 7:52 PM

Change 406610 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] icons: Remove 'bellOn', deprecated in v0.25.0

https://gerrit.wikimedia.org/r/406610

Volker_E moved this task from Waiting for breaking release to OOUI-0.26.0 on the OOUI board.Mar 20 2018, 7:55 PM
Volker_E edited projects, added OOUI (OOUI-0.26.0); removed OOUI.
Volker_E closed this task as Resolved.Mar 20 2018, 8:03 PM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Mar 23 2018, 2:05 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL