Page MenuHomePhabricator
Create Task
Maniphest T145228

Typehint issue in UploadStash::__construct() (causes uploads from stash via Special:Upload to fatal)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Catchable fatal error: Argument 2 passed to UploadStash::__construct() must be an instance of User, bool given
in /srv/mediawiki/php-1.28.0-wmf.18/includes/upload/UploadStash.php on line 94

Details

ProjectBranchLines +/-Subject
mediawiki/corewmf/1.28.0-wmf.18+21 -9Revert "Clean up user handling in UploadStash"
mediawiki/coremaster+21 -9Revert "Clean up user handling in UploadStash"
Customize query in gerrit

Related Objects

Event Timeline

Dereckson created this task.Sep 9 2016, 7:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2016, 7:24 PM
matmarex renamed this task from Typehint issue in UploadStash::__construct() to Typehint issue in UploadStash::__construct() (causes uploads from stash via Special:Upload to fatal).Sep 10 2016, 3:27 PM
matmarex claimed this task.
matmarex triaged this task as Unbreak Now! priority.
matmarex added a project: MediaWiki-Uploading.
Restricted Application added a project: Multimedia. · View Herald TranscriptSep 10 2016, 3:27 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald Transcript
matmarex merged a task: T145272: File Upload 500 in mediawiki.org.Sep 10 2016, 3:27 PM
matmarex added subscribers: 01tonythomas, Matanya.
gerritbot added a subscriber: gerritbot.Sep 10 2016, 3:27 PM

Change 309736 had a related patch set uploaded (by Bartosz Dziewoński):
Revert "Clean up user handling in UploadStash"

https://gerrit.wikimedia.org/r/309736

gerritbot added a project: Patch-For-Review.Sep 10 2016, 3:27 PM
matmarex added a comment.Sep 10 2016, 3:37 PM

This results in a fatal when Special:Upload tries to upload a file from stash (this happens if the user gets a warning on the initial upload attempt; the file is stashed so that it doesn't have to be reuploaded if only file name or description needs correcting). There are around 100-200 instances per day in logstash (so presumably 100-200 uploads that could not be completed).

Dereckson moved this task from Untriaged to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.Sep 10 2016, 5:36 PM
gerritbot added a comment.Sep 11 2016, 12:35 AM

Change 309736 merged by jenkins-bot:
Revert "Clean up user handling in UploadStash"

https://gerrit.wikimedia.org/r/309736

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), MW-1.28-release-notes.Sep 11 2016, 1:00 AM
gerritbot added a comment.Sep 11 2016, 2:57 AM

Change 309813 had a related patch set uploaded (by Dereckson):
Revert "Clean up user handling in UploadStash"

https://gerrit.wikimedia.org/r/309813

gerritbot added a comment.Sep 12 2016, 1:23 PM

Change 309813 merged by jenkins-bot:
Revert "Clean up user handling in UploadStash"

https://gerrit.wikimedia.org/r/309813

Stashbot added a subscriber: Stashbot.Sep 12 2016, 1:31 PM

Mentioned in SAL [2016-09-12T13:31:22Z] <hashar@tin> Synchronized php-1.28.0-wmf.18/includes/upload/UploadStash.php: Revert "Clean up user handling in UploadStash" T145228 (duration: 00m 46s)

Stashbot added a comment.Sep 12 2016, 1:32 PM

Mentioned in SAL [2016-09-12T13:32:32Z] <hashar@tin> Synchronized php-1.28.0-wmf.18/maintenance/cleanupUploadStash.php: Revert "Clean up user handling in UploadStash" T145228 (duration: 00m 46s)

matmarex closed this task as Resolved.Sep 12 2016, 1:43 PM
matmarex edited projects, added MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)); removed Patch-For-Review.

Fixed and deployed.

Krinkle moved this task from Mar 2019 / 1.33wmf20-23 to Resolved on the Wikimedia-production-error board.Mar 19 2019, 3:33 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL