Page MenuHomePhabricator

[regression-wmf.18] Notifications from deleted Flow topics are not purged
Closed, ResolvedPublic

Description

This was tested in betalabs.
When checking T93673: Remove Notifications about posts/topics that have been Moderated, it was found that notifications that came from deleted Flow topics will not be purged from Notification panel or from Special: Notiifcations - we had a similar case for moderated posts in T142758: Notifications from moderated post are not purged.

Note: Re-checked notifications from moderated posts/page (Flow and wikitext) - such notifications won't be visible.

  1. Login as two different users in two different browsers.
  2. User A creates a topic (and it's added automatically to his watchlist)
  3. User B changes the topic title, adds a summary, thanks user A, edits a user A's reply, adds a reply.
  4. User A successfully receives the correct number of notifications about all above events.
  5. User B deletes the topic.
  6. User A still sees all notifications that came from the deleted topic. When they are clicked, a user A will be redirected to

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 9 2016, 7:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 310058 had a related patch set uploaded (by Sbisson):
Actually insert target page entries when creating an Event

https://gerrit.wikimedia.org/r/310058

Change 310058 merged by jenkins-bot:
Actually insert target page entries when creating an Event

https://gerrit.wikimedia.org/r/310058

Checked in betalabs - loos good: all notifications from moderated topics are removed from view.