Add hijri calendar option in Urdu
Open, MediumPublic
Actions

Assigned To

None

Authored By

	MuhammadShuaib
	Sep 10 2016, 8:55 AM

Description

Please enable hijri calendar on Urdu wikipedia.
Local consensus is here.

Details

	Subject	Repo	Branch	Lines +/-
	Add hijri calender For Urdu wikis and some other date preferences	mediawiki/core	master	+30 -1
	Add Hijri calendar in Urdu	mediawiki/core	master	+20 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T145266 Add hijri calendar option in Urdu
		Resolved		zeljkofilipin	T189451 Jenkins fails to merge a patch with "Unexpected token function"

Event Timeline

MuhammadShuaib created this task.Sep 10 2016, 8:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2016, 8:55 AM

Change 309724 had a related patch set (by محمد شعیب) published:
It is requested by Urdu Wikipedia community to add Hijri calendar in Urdu, so that users can select their preferred calendar from Preferences.

https://gerrit.wikimedia.org/r/309724

gerritbot added a project: Patch-For-Review.Sep 10 2016, 9:46 AM

• MZMcBride subscribed.Sep 10 2016, 9:49 AM

Please enable it soon.

Nemo_bis renamed this task from Enable hijri calender in Urdu to Add hijri calendar option in Urdu.Nov 6 2016, 12:17 PM

Nemo_bis triaged this task as Medium priority.

MuhammadShuaib raised the priority of this task from Medium to High.Mar 7 2018, 7:05 AM

As this patch has been uploaded in sep 2016 but not yet been deployed, I set its priority from normal to High. Hope that patch will be merged soon.

MuhammadShuaib added subscribers: Amire80, MarcoAurelio.Mar 7 2018, 7:12 AM

@MuhammadShuaib: Age of an existing patch does not make a task more urgent. The Priority field reflects reality and does not cause it (which can be frustrating sometimes, sorry). Thanks for your understanding.

MarcoAurelio unsubscribed.Mar 7 2018, 10:09 AM

In T145266#4031122, @Aklapper wrote:

@MuhammadShuaib: Age of an existing patch does not make a task more urgent. The Priority field reflects reality and does not cause it (which can be frustrating sometimes, sorry). Thanks for your understanding.

zeljkofilipin closed subtask T189451: Jenkins fails to merge a patch with "Unexpected token function" as Resolved.Mar 12 2018, 11:05 AM

Change 309724 merged by Amire80:
[mediawiki/core@master] Add Hijri calendar in Urdu

https://gerrit.wikimedia.org/r/309724

Amire80 moved this task from Untriaged to Date and time on the I18n board.Mar 12 2018, 11:36 AM

Merged finally. This should become available for testing on https://ur.wikibooks.org on Wednesday March 14 late at night, and on https://ur.wikipedia.org on Thursday March 15 late at night.

It should be tested then, and if it works, the task can be finally marked as resolved.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 12 2018, 12:00 PM

In T145266#4042615, @Amire80 wrote:

Merged finally. This should become available for testing on https://ur.wikibooks.org on Wednesday March 14 late at night, and on https://ur.wikipedia.org on Thursday March 15 late at night.

It should be tested then, and if it works, the task can be finally marked as resolved.

Is it deployed?

@MuhammadShuaib: I don't understand the question. Did you test? If yes, where? If yes, did it work? If not, can you provide steps?

It is deployed to Wikibooks already, but there was a bug in the patch, so you cannot see the change. It doesn't break anything, but the fix is incomplete. I'll submit a follow up patch soon.

In T145266#4053266, @Amire80 wrote:

It is deployed to Wikibooks already, but there was a bug in the patch, so you cannot see the change. It doesn't break anything, but the fix is incomplete. I'll submit a follow up patch soon.

Oh, thanks. :)

Waiting for this patch. :)

Change 386036 had a related patch set uploaded (by Winston Sung; author: Obaid Raza):

[mediawiki/core@master] Add hijri calender For Urdu wikis and some other date preferences

https://gerrit.wikimedia.org/r/386036

Change 386036 abandoned by Winston Sung:

[mediawiki/core@master] Add hijri calender For Urdu wikis and some other date preferences

Reason:

Replaced-by: I7299d0f84f629da781b100c4db6b2a30a7d1bb86