Page MenuHomePhabricator
Create Task
Maniphest T145301

ve.dm.APIResultsProvider seems to be mostly dead code; abstract it?
Open, LowPublic8 Estimated Story Points
Actions

Description

When working on T143279, I couldn't help but think that ve.dm.APIResultsProvider is mostly dead code. Its only subclass, ve.dm.MWMediaResourceProvider, overrides just about everything. Pretty sure that a bunch of ve.dm.APIResultsProvider's methods should be removed or made abstract. In particular, getAjaxSettings/setAjaxSettings are never used (only in the subclass), and getResults is overridden by the subclass without calling the parent (and the code in it makes no sense).

Related Objects

Event Timeline

matmarex created this task.Sep 10 2016, 8:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2016, 8:01 PM
Esanders subscribed.Sep 12 2016, 7:55 PM

Plausibly having an abstract parent class would make sense here, and it could be used in other cases we want to infinite-scroll a set of API results, e.g. T144069. So we may want to fix it rather than delete it.

Jdforrester-WMF renamed this task from ve.dm.APIResultsProvider seems to be mostly dead code to ve.dm.APIResultsProvider seems to be mostly dead code; abstract it?.Sep 13 2016, 7:09 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Esanders changed the point value for this task from 1 to 8.Sep 15 2016, 6:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL