Page MenuHomePhabricator seems to be mostly dead code; abstract it?
Open, LowPublic8 Estimated Story Points


When working on T143279, I couldn't help but think that is mostly dead code. Its only subclass,, overrides just about everything. Pretty sure that a bunch of's methods should be removed or made abstract. In particular, getAjaxSettings/setAjaxSettings are never used (only in the subclass), and getResults is overridden by the subclass without calling the parent (and the code in it makes no sense).

Event Timeline

Plausibly having an abstract parent class would make sense here, and it could be used in other cases we want to infinite-scroll a set of API results, e.g. T144069. So we may want to fix it rather than delete it.

Jdforrester-WMF renamed this task from seems to be mostly dead code to seems to be mostly dead code; abstract it?.Sep 13 2016, 7:09 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Esanders changed the point value for this task from 1 to 8.Sep 15 2016, 6:39 PM