| Esanders | |
| Sep 10 2016, 9:57 PM |
| F4494481: Screen Shot 2016-09-20 at 10.17.01 PM.png | |
| Sep 20 2016, 9:23 PM |
| F4465407: selected-hover-tooltip.png | |
| Sep 13 2016, 9:55 PM |
| F4454946: pasted_file | |
| Sep 10 2016, 9:57 PM |
We use these hacks in MW theme to ensure the correct border appears on top, but having plain widgets set z-indexes is really horrible, as it means the rest of the z-index stack of the UI has to be designed around them.
Here's an example of the VE mobile standalone demo failing, for example:
While in MW our overlays have a higher z-index, other users may not want to / may not be able to increase the z-index of overlays.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| MediaWiki theme: Refactor z-index inside ButtonSelectWidget/ButtonGroupWidget | oojs/ui | master | +40 -12 |
The selected/non-selected border colours are currently very similar shades of grey, so just removing this z-index will result be fairly un-noticeable.
This could probably be resolved by creating a stacking context on the ButtonGroupWidget/ButtonSelectWidget/whatever?
Yes. And also,
.oo-ui-buttonSelectWidget {
z-index: 0;
position: relative;
}…to create a stacking context and prevent the .oo-ui-buttonOptionWidget z-index from "leaking out". (Similar for ButtonGroupWidget probably.)
I think this screenshot from T145579 makes the issue clearer:
Change 310806 had a related patch set uploaded (by Bartosz Dziewoński):
MediaWiki theme: Refactor z-index inside ButtonSelectWidget/ButtonGroupWidget
Change 310806 merged by jenkins-bot:
MediaWiki theme: Refactor z-index inside ButtonSelectWidget/ButtonGroupWidget
I still that see that active buttons are appearing over the tooltip, however it got fixed for hovered buttons, I can no more hover or click through buttons over the tooltip.
Reopening it since it seems not completely fixed.
It's fixed in OOjs UI 0.18.0 which isn't anywhere yet. It'll get into wmf.22, probably. Given the size of the patch, I don't think it's worth trying to pull it in early.