Convert ArticleRatings to use JSON for extension registration and i18n
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	SamanthaNguyen
	Sep 11 2016, 12:04 AM

Description

Currently, ArticleRating uses extension registration with the PHP file, [[https://phabricator.wikimedia.org/diffusion/1897/browse/master/ArticleRatings.php|ArticleRatings.php]], and i18n with PHP at [[https://phabricator.wikimedia.org/diffusion/1897/browse/master/ArticleRatings.i18n.php|ArticleRatings.i18n.php]], these should be replaced with their respective JSON files.

Details

	Subject	Repo	Branch	Lines +/-
	Delete the old PHP i18n file for good	mediawiki/extensions/ArticleRatings	master	+0 -49
	Modernize the extension, ditch PHP entry point and i18n file	mediawiki/extensions/ArticleRatings	master	+234 -175

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Subtype	Assigned	Task
			· · ·
Open	Goal	None	T98668 Convert all extensions and skins on gerrit to use extension registration
Resolved		SamanthaNguyen	T145313 Convert ArticleRatings to use JSON for extension registration and i18n
			· · ·

Event Timeline

SamanthaNguyen created this task.Sep 11 2016, 12:04 AM

SamanthaNguyen moved this task from Backlog to Feedback / Suggestions on the ArticleRatings board.

SamanthaNguyen moved this task from Backlog to ArticleRatings (ARE) on the Brickimedia board.Sep 11 2016, 1:04 AM

Change 309828 had a related patch set uploaded (by Jack Phoenix):
Modernize the extension, ditch PHP entry point and i18n file

https://gerrit.wikimedia.org/r/309828

gerritbot added a project: Patch-For-Review.Sep 11 2016, 12:03 PM

ashley mentioned this in rEARA892ca95dcb95: Modernize the extension, ditch PHP entry point and i18n file.Sep 11 2016, 5:23 PM

Liuxinyu970226 added a parent task: T98668: Convert all extensions and skins on gerrit to use extension registration.Sep 12 2016, 5:51 AM

Change 309828 merged by Legoktm:
Modernize the extension, ditch PHP entry point and i18n file

https://gerrit.wikimedia.org/r/309828

SamanthaNguyen moved this task from Feedback / Suggestions to Feedback on the ArticleRatings board.Sep 19 2016, 2:49 AM

Didn't look carefully (sorry!), turns out that the ArticleRatings.i18n.php file wasn't actually removed. Can you submit another patch to remove it and close the task once it's merged? :)

Change 311622 had a related patch set uploaded (by Jack Phoenix):
Delete the old PHP i18n file for good

https://gerrit.wikimedia.org/r/311622

ashley mentioned this in rEARA2ef7c1b9eebb: Delete the old PHP i18n file for good.Sep 19 2016, 11:14 PM

Change 311622 merged by SamanthaNguyen:
Delete the old PHP i18n file for good

https://gerrit.wikimedia.org/r/311622

SamanthaNguyen closed this task as Resolved.Sep 22 2016, 11:33 PM

SamanthaNguyen claimed this task.

SamanthaNguyen removed a project: Patch-For-Review.

Aklapper removed a subscriber: Brickimedia.May 16 2023, 10:26 AM