Break down monuments_config in individual JSON files
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JeanFred
	Sep 11 2016, 4:18 PM

Description

(I thought we had a task for that but cannot find it anymore?)

monuments_config.py is a nightmare to edit. Let’s break it down into smaller JSON files for each config.

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Break down monuments_config in individual JSON files	labs/tools/heritage	master	+9 K -8 K

		Status	Subtype	Assigned	Task
		Resolved		JeanFred	T145333 Break down monuments_config in individual JSON files
		Open		None	T147751 Update instructions for adding a new source

Would it be possibly to reuse the current test logic (test_monuments_config and test_fill_page IIRC) if we do this?

(To clarify, I still think breaking the behemoth up into small jsons is the way to go)

Change 313766 had a related patch set uploaded (by Jean-Frédéric):
Break down monuments_config in individual JSON files

This was done with P4142

Change 313766 merged by jenkins-bot:
Break down monuments_config in individual JSON files

JeanFred closed this task as Resolved.Oct 12 2016, 8:56 AM