Page MenuHomePhabricator

[addwiki/mediawiki-api] Add a method to PagePurger for purging multiple pages at once
Closed, ResolvedPublic

Description

The PagePurger currently only accepts a single Page:

PagePurger::purge( Page $page );

It should also have a method that accepts a Pages object.

Event Timeline

I can work on this. I searched for PagePurger but it doesnt exist. In which file should I poke around ?

Zppix renamed this task from [mediawiki-api] add method to PagePurger to purging multiple pages at once to add a method to PagePurger for purging multiple pages at once.Oct 30 2016, 5:34 PM
Zppix added a project: MediaWiki-Action-API.
Zppix moved this task from Backlog to Ready to go on the good first task board.

I can work on this. I searched for PagePurger but it doesnt exist.

In which codebase did you search, and how? See https://phabricator.wikimedia.org/project/profile/1490/ for more information.

Samwilson renamed this task from add a method to PagePurger for purging multiple pages at once to [addwiki/mediawiki-api] Add a method to PagePurger for purging multiple pages at once.Oct 31 2016, 1:38 AM
Samwilson updated the task description. (Show Details)

@Zppix: I re-added the package name as a prefix to this task's title. Note that that is about a client API package for interacting with the MediaWiki API, not about the API itself.

Everyone: I added a note to the task description about accepting a Pages object, but really that's just an idea and I haven't got a use case in mind myself. (Oh, actually I do: in integration tests I quite often create test pages and categories, and it'd be nice and possibly quicker to be able to purge them in one fell swoop.)

I created a pull request at github

I want to write some testing too, how can I get started ? Which tools/frameworks does the project use ?

I want to write some testing too, how can I get started ? Which tools/frameworks does the project use ?

Hi @Blackspirit96!

The projects all use phpunit for tests!

I recently made a commit to the mediawiki-api-base library making the testing all 'super nice'.
https://github.com/addwiki/mediawiki-api-base/commit/58b030683b58c7c8b31d6abe5dafd9aaad0c38cb
I'll try and do the same for the mediawiki-api library!