We should separate FileAnnotator class from code in fileannotations.js that should run on page load. It would allow for some testability and reusability – for example I don't think we can do T58666 without that?
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Move bulk of code to single-class file | MarkTraceur | mediawiki/extensions/FileAnnotations | master | +575 -565 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | MarkTraceur | T144302 Release FileAnnotations on the Beta Cluster | |||
| Resolved | MarkTraceur | T145450 Separate FileAnnotator class from code in fileannotations.js that should run on page load |
Event Timeline
Comment Actions
Change 311445 had a related patch set uploaded (by MarkTraceur):
Move bulk of code to single-class file