Parsoid needs to be updated to be compatible with magic links being disabled (T47942: "Magic links" RFC, PMID and ISBN should be configurable and disableable).
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T31473 Magic Linking (tracking) | |||
| Open | None | T162291 Autolinking for URLs and magic links (ISBN etc.) not applied when copy-pasting a block of text | |||
| Duplicate | None | T219627 Sometimes an ISBN turns up wrapped in nowiki-tags | |||
| Resolved | cscott | T179769 VisualEditor converts interwiki/Special:BookSources links to magic links | |||
| Open | None | T145604 RFC: Future of magic links | |||
| Resolved | cscott | T145590 Update Parsoid to be compatible with magic links being disabled | |||
| Resolved | Legoktm | T47942 "Magic links" RFC, PMID and ISBN should be configurable and disableable |
Event Timeline
Comment Actions
Change 310453 had a related patch set uploaded (by Legoktm):
API: Expose $wgEnableMagicLinks in meta=siteinfo
Comment Actions
Change 310453 merged by jenkins-bot:
API: Expose $wgEnableMagicLinks in meta=siteinfo
Comment Actions
The magic link configuration is exposed in siteinfo (thanks, @Legoktm!). It was probably not included in the SiteConfig we created during the Parsoid/PHP port, because nothing in Parsoid is/was using it. So we probably need to (1) expose that, (2) add a few feature flag tests to the tokenizer rules which match magic links, (3) add similar feature flag tests to the html2wt serializer rules which protect magic link-like text during serialization (Wikimedia\Parsoid\Html2Wt\ConstrainedText::fromSelSerImpl), and (4) figure out/test a migration strategy for how Parsoid ought to deal with selser when the previously-parsed article/unedited content contains magic links.
Comment Actions
I think the behavior we want is:
- If magic links are enabled:
- ✅ PMID 123 turns into an external link, along the lines of <a href="//www.ncbi.nlm.nih.gov/pubmed/123?dopt=Abstract" rel="mw:ExtLink nofollow" class="external mw-magiclink" id="mwAw">PMID 123</a>
- ✅ <a href="//www.ncbi.nlm.nih.gov/pubmed/123?dopt=Abstract" rel="mw:ExtLink nofollow" class="external mw-magiclink" id="mwAw">PMID 123</a> turns into PMID 123
- ✅ [[pmid:123|PMID 123]] turns into an interwiki link, along the lines of <a rel="mw:WikiLink/Interwiki" href="https://www.ncbi.nlm.nih.gov/pubmed/123?dopt=Abstract" title="pmid:123" class="extiw" id="mwAw">PMID 123</a>
- ❎ <a rel="mw:WikiLink/Interwiki" href="https://www.ncbi.nlm.nih.gov/pubmed/123?dopt=Abstract" title="pmid:123" class="extiw" id="mwAw">PMID 123</a> turns into [[pmid:123|PMID 123]] (per T179769)
- Currently turns into a magic link, PMID 123.
- If magic links are disabled:
- ❎ PMID 123 is treated as plain text
- Currently expanded as a magic link
- ❎ <a href="//www.ncbi.nlm.nih.gov/pubmed/123?dopt=Abstract" rel="mw:ExtLink nofollow" class="external mw-magiclink" id="mwAw">PMID 123</a> turns into either [//www.ncbi.nlm.nih.gov/pubmed/123?dopt=Abstract PMID 123] or [[pmid:123|PMID 123]]
- Currently converted to PMID 123, as if it was a magic link
- ✅ [[pmid:123|PMID 123]] turns into an interwiki link, along the lines of <a rel="mw:WikiLink/Interwiki" href="https://www.ncbi.nlm.nih.gov/pubmed/123?dopt=Abstract" title="pmid:123" class="extiw" id="mwAw">PMID 123</a>
- ❎ <a rel="mw:WikiLink/Interwiki" href="https://www.ncbi.nlm.nih.gov/pubmed/123?dopt=Abstract" title="pmid:123" class="extiw" id="mwAw">PMID 123</a> turns into [[pmid:123|PMID 123]]
- Currently turns into a magic link, PMID 123.
- ❎ PMID 123 is treated as plain text
Comment Actions
@Legoktm enwiki has interwiki mappings for RFC [[rfc:123]] and PMID [[pmid:1234]] but not ISBN. Is the principal you're proposing above that html2wt should *always* prefer an interwiki mapping, if it exists, over a magic link serialization (whether magic links are enabled or not)? I can see why you'd want this, although strictly speaking it breaks round-tripping.
It's hard to test this because the parser test environment doesn't have the interwiki mappings for pmid and rfc.
Comment Actions
Change 982922 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/services/parsoid@master] Update Parsoid to be compatible with magic links being disabled
Comment Actions
Change 983281 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] ParserTestRunner: add [[pmid:]] interwiki prefix
Comment Actions
Change 1004200 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/core@master] [Parsoid\Config\SiteConfig] enable Parsoid support for disabling magic links
Comment Actions
Change 983281 merged by jenkins-bot:
[mediawiki/core@master] ParserTestRunner: add [[pmid:]] interwiki prefix
Comment Actions
Change 1004200 merged by jenkins-bot:
[mediawiki/core@master] [Parsoid\Config\SiteConfig] enable Parsoid support for disabling magic links
Comment Actions
Change #982922 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Update Parsoid to be compatible with magic links being disabled
Comment Actions
Change #1076829 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a23
Comment Actions
Change #1076829 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a23