Page MenuHomePhabricator
Create Task
Maniphest T145597

Contributions offset broken on test wikipedia
Closed, ResolvedPublic
Actions

Description

Looks like https://gerrit.wikimedia.org/r/#/c/260636/ broke the offsets parameter on Special:Contributions:
https://test.wikipedia.org/w/index.php?title=Special:Contributions/Kaldari&offset=20141102191202&target=Kaldari

That code hasn't hit the real wikis yet, but we'll need to SWAT deploy a fix tomorrow morning.

Details

SubjectRepoBranchLines +/-
Partially reverting I8e684f06 to restore some legacy behaviormediawiki/corewmf/1.28.0-wmf.19+12 -20
Partially reverting I8e684f06 to restore some legacy behaviormediawiki/coremaster+12 -20
Customize query in gerrit

Event Timeline

kaldari created this task.Sep 14 2016, 12:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2016, 12:30 AM
kaldari triaged this task as High priority.Sep 14 2016, 12:31 AM
gerritbot subscribed.Sep 14 2016, 1:27 AM

Change 310476 had a related patch set uploaded (by Kaldari):
Partially reverting I8e684f06 to restore some legacy behavior

https://gerrit.wikimedia.org/r/310476

gerritbot added a project: Patch-For-Review.Sep 14 2016, 1:27 AM
gerritbot added a comment.Sep 14 2016, 1:48 AM

Change 310476 merged by jenkins-bot:
Partially reverting I8e684f06 to restore some legacy behavior

https://gerrit.wikimedia.org/r/310476

gerritbot added a comment.Sep 14 2016, 1:49 AM

Change 310478 had a related patch set uploaded (by Kaldari):
Partially reverting I8e684f06 to restore some legacy behavior

https://gerrit.wikimedia.org/r/310478

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)), MW-1.28-release-notes.Sep 14 2016, 2:00 AM
kaldari updated the task description. (Show Details)Sep 14 2016, 3:51 AM

SWAT deployment scheduled for tomorrow morning before the train.

gerritbot added a comment.Sep 14 2016, 6:12 PM

Change 310478 merged by jenkins-bot:
Partially reverting I8e684f06 to restore some legacy behavior

https://gerrit.wikimedia.org/r/310478

Stashbot subscribed.Sep 14 2016, 6:23 PM

Mentioned in SAL (#wikimedia-operations) [2016-09-14T18:23:20Z] <thcipriani@tin> Synchronized php-1.28.0-wmf.19/includes/pager/ReverseChronologicalPager.php: SWAT: [[gerrit:310478|Partially reverting I8e684f06 to restore some legacy behavior (T145597)]] (duration: 00m 48s)

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 14 2016, 7:00 PM
kaldari closed this task as Resolved.Sep 14 2016, 7:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL