Page MenuHomePhabricator

Move Revision Slider view to show latest revision bars where possible
Open, Needs TriagePublic

Description

Hi. I'd like to suggest something that can help for visuality of the slider. A lot of times we open some revisions diff, and slider starts with blue arrow at the end of the graph, but there is enough place to see the zero revision. So we need move the slider and then continue. Could you please change it so if the number of revisions between prev and cur is less than slider width, the last revision column will appear in the first place? Thank you very much.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@IKhitron, I'm afraid I don't understand the meaning of your proposal. Could you please create a screenshot and add annotations/captions on it with explanation of what part of the slider you propose to change?

No problem. I'll send it to you by email, and you can use it or create a video for this task, if you want to.

Thank you for the video, @Guycn2. You can find it here.

Thanks for the video!
Personally I agree! :)

@IKhitron would you say that centring the selected revisions in the slider would make the most sense?

Sorry, not at all, @Addshore. If there two few revisions between diff and cur, it will not work, and if too many, it will not help.

Addshore renamed this task from Move Revision Slider view to Move Revision Slider view to show latest revision bars where possible.Sep 22 2016, 10:50 AM

@lKhitron we discussed the issue today, and we agree that the revisionslider is currently not ideal to immediately compare something with the newest version. However, currently we do one API call to get the revisions after a certain revision id. We do not know, if that revision id is the newest revision or any other one. If we wanted to implement any solution that does not have the two revisions on the most right side, we would have to do another API call (or have them on the very left, which would be a bit weird whenever they are indeed the newest versions). Since this would slow down the loading time of the revision slider, we are not implementing the suggestion right now. We will continue to think how to improve the situation, though

Extreme case mentioned by @MichaelSchoenitzer_WMDE in T151359:

When I click on a diff-link that is not the newest diff-link but for example the second newest edit of that page, the revision-slider is positioned in a way that it looks like the version I'm seeing (on the right side) is the newest version but in reality there is one newer version "hidden" and has to be brought into sight by clicking on the 'see newer versions'-button. Example
I found this very confusing and non intuitive – especially if you don't come from the version history but for example from the watchlist. When this happened to me the first time I search for quiet some time for the "lost" edit.