Page MenuHomePhabricator
Create Task
Maniphest T145652

BUG: 'Save for later' does not toggle on/off if article was opened via Safari
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

If an article was opened in the app via a deep link from Safari, the 'Save for later' button does not appear responsive when tapped (bookmark outline icon does not become filled).

Occurring on
Originally reported through OTRS by a user on: Wikipedia app 5.1.1.920.1 (iPhone OS 10.0.1)
I was able to replicate the bug on: Wikipedia app 5.2.0.939 (iPhone 6S Plus iOS 10.0.1)

Steps to reproduce

  1. Open the Wikipedia website on Safari
  2. Select to open an article in the Wikipedia app (ensure the article is not already on your 'Save for later list)
  3. With the article now open in the app, tap on the "Save for later" bookmark icon.

Expected
"Save for later" bookmark button toggles to the filled icon state to indicate that the article has been saved.

Actual
"Save for later" icon remains in the same unfilled state.

Video showing behavior is here:
https://youtu.be/pUxdV3Ym4qc

Related Objects

Event Timeline

RHo created this task.Sep 14 2016, 3:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2016, 3:15 PM
RHo updated the task description. (Show Details)Sep 14 2016, 3:26 PM
RHo mentioned this in T145658: BUG: "Save for later" articles added after the list is viewed do not appear to be added to the list.Sep 14 2016, 4:02 PM
RHo added projects: iOS-app-Bugs, Wikipedia-iOS-App-Backlog.
RHo removed a subscriber: iOS-app-Bugs.
JoeWalsh claimed this task.Sep 14 2016, 4:28 PM
JoeWalsh added a project: iOS-app-v5.2.1-Egg-Tart.
JoeWalsh set the point value for this task to 3.
JoeWalsh moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.2.1-Egg-Tart board.
• JMinor triaged this task as Medium priority.Sep 14 2016, 4:38 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
JoeWalsh moved this task from Doing to Needs Code Review on the iOS-app-v5.2.1-Egg-Tart board.Sep 14 2016, 5:26 PM

https://github.com/wikimedia/wikipedia-ios/pull/903

Diffusion mentioned this in rAPIOSeefba3cbe24e: Merge branch 'develop' into bug/save_from_safari/T145652.Sep 14 2016, 10:45 PM
JoeWalsh moved this task from Needs Code Review to Needs QA on the iOS-app-v5.2.1-Egg-Tart board.Sep 15 2016, 2:37 PM

Testing Criteria:

Ensure the "Steps to Reproduce" produce the expected results.

JoeWalsh mentioned this in rAPIOS764fd3ea1c0b: Merge pull request #903 from wikimedia/bug/save_from_safari/T145652.Sep 15 2016, 3:14 PM
Nicholas.tsg subscribed.Sep 15 2016, 9:44 PM

Testing with iPhone 6S (iOS 10.0.1) and Wikipedia 5.2.0 (939). This is fixed as I opened a Wikipedia article from Safari and the bookmark filled when I tapped it (it also appeared under the Saved tab).

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.2.1-Egg-Tart board.Sep 15 2016, 9:44 PM
• JMinor closed this task as Resolved.Sep 19 2016, 9:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL