Page MenuHomePhabricator
Create Task
Maniphest T145691

Link suggestions in content translation sometimes missing
Closed, ResolvedPublic
Actions

Description

How to reproduce:

  1. Invoke content translation from [[en:Torch (machine learning)]] to translate to Hebrew
  2. Press on Lua
  3. expectation: suggestion to add a link to "לואה (שפת תכנות)" (Hebrew article for Lua)

actual: missing article

Details

SubjectRepoBranchLines +/-
Links: Keep original and redirect resolved source title in linkpair cachemediawiki/extensions/ContentTranslationmaster+18 -9
Customize query in gerrit

Event Timeline

eranroz created this task.Sep 14 2016, 9:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2016, 9:00 PM
Amire80 triaged this task as High priority.Oct 2 2016, 1:43 PM
Amire80 added projects: Regression, Essential-Work.
Amire80 subscribed.

I can reproduce this. This is very odd—the article about Lua exists in Hebrew and should be adapted.

High-priority: link adaptation is a pretty core functionality, and should be working.

Amire80 added a project: Language-Engineering October-December 2016.Oct 2 2016, 1:43 PM
Amire80 added a project: Language-Q2-2016-17 Sprint 1.Oct 2 2016, 1:53 PM
Arrbee moved this task from Backlog to CX-Maintenance on the Language-Engineering October-December 2016 board.Oct 3 2016, 6:44 AM
santhosh claimed this task.Oct 4 2016, 8:24 AM
santhosh added a comment.Oct 4 2016, 8:27 AM

This was a special case, not a general link adaptation failure or regression. The first paragraph of [[en:Torch (machine learning)]] had two links , one with target as LuaJIT and another with Lua (programing language), both points to same English wikipage: Lua (programing language).
While populating linkPairs, we put entry for redirect resolved source and left another and lookup for another failed.
Fixing..

gerritbot subscribed.Oct 4 2016, 8:28 AM

Change 313962 had a related patch set uploaded (by Santhosh):
Links: Keep original and redirect resolved source title in linkpair cache

https://gerrit.wikimedia.org/r/313962

gerritbot added a project: Patch-For-Review.Oct 4 2016, 8:28 AM
santhosh moved this task from Backlog to In Review on the Language-Q2-2016-17 Sprint 1 board.Oct 4 2016, 8:29 AM
Amire80 moved this task from Needs Triage to Oct.-Dec. 2016 on the ContentTranslation board.Oct 9 2016, 12:29 PM
Amire80 moved this task from In Review to QA on the Language-Q2-2016-17 Sprint 1 board.Oct 10 2016, 11:16 AM
gerritbot added a comment.Oct 10 2016, 11:24 AM

Change 313962 merged by jenkins-bot:
Links: Keep original and redirect resolved source title in linkpair cache

https://gerrit.wikimedia.org/r/313962

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 10 2016, 12:00 PM
Arrbee closed this task as Resolved.Oct 13 2016, 7:08 AM
Arrbee subscribed.

Verified.

Arrbee moved this task from QA to Done on the Language-Q2-2016-17 Sprint 1 board.Oct 13 2016, 7:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits