Page MenuHomePhabricator
Create Task
Maniphest T145714

ComboBoxInputWidget (empty)‎ falsely features a dropdown indicator
Closed, ResolvedPublic
Actions

Description

ComboBoxInputWidget (empty)‎ currently (as of v0.17.9) features a dropdown indicator even if there's no dropdown menu available. This leads to unmet user expectations.
Let's hide it!

T145714 ComboBoxInputWidget (empty) - OOjs UI Demos 2016-09-14.png (70×660 px, 7 KB)

T145714 ComboBoxInputWidget (empty) - OOjs UI Demos 2016-09-14.mp4242 KBDownload

Originated in discussions at T87832.

Details

SubjectRepoBranchLines +/-
ComboBoxInputWidget: Hide dropdown indicator when there is no dropdownoojs/uimaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Sep 15 2016, 12:29 AM
Restricted Application added a project: UI-Standardization. · View Herald TranscriptSep 15 2016, 12:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E updated the task description. (Show Details)Sep 15 2016, 12:37 AM
Volker_E updated the task description. (Show Details)
Volker_E edited subscribers, added: Pginer-WMF, Jdforrester-WMF, matmarex; removed: Pgehres.
gerritbot subscribed.Sep 15 2016, 12:52 AM

Change 310716 had a related patch set uploaded (by VolkerE):
ComboBoxInputWidget: Hide dropdown indicator when there is no dropdown

https://gerrit.wikimedia.org/r/310716

gerritbot added a project: Patch-For-Review.Sep 15 2016, 12:52 AM
Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.Sep 15 2016, 12:54 AM
gerritbot added a comment.Sep 15 2016, 4:22 PM

Change 310716 merged by jenkins-bot:
ComboBoxInputWidget: Hide dropdown indicator when there is no dropdown

https://gerrit.wikimedia.org/r/310716

Volker_E closed this task as Resolved.Sep 15 2016, 5:04 PM
Volker_E removed a project: Patch-For-Review.
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.
Jdforrester-WMF moved this task from Backlog to OOjs-UI-0.18.0 on the OOUI board.Sep 19 2016, 3:48 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.18.0); removed OOUI.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL