Page MenuHomePhabricator
Create Task
Maniphest T145715

Cannot open VE on test2, getting error "TypeError: Right-hand side of 'instanceof' is not an object "
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Cannot open VE on test2 for this page: https://test2.wikipedia.org/wiki/User:RYasmeen_(WMF)?veaction=edit

Getting error "TypeError: Right-hand side of 'instanceof' is not an object "

Screen Shot 2016-09-14 at 5.47.27 PM.png (691×1 px, 202 KB)

Related Objects

Event Timeline

Ryasmeen created this task.Sep 15 2016, 12:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2016, 12:47 AM
• AlexMonk-WMF subscribed.Sep 15 2016, 12:49 AM

This is probably the same bug I'm fixing in https://gerrit.wikimedia.org/r/310713

• AlexMonk-WMF added a project: ProofreadPage.Sep 15 2016, 12:49 AM
matmarex subscribed.Sep 15 2016, 2:20 AM

(See also https://gerrit.wikimedia.org/r/309987 about the error message being dumb.)

• AlexMonk-WMF closed this task as Resolved.Sep 15 2016, 4:05 PM
• AlexMonk-WMF claimed this task.

Merged, filed T145790 for Jenkins

Ryasmeen added a project: Verified.Sep 15 2016, 7:55 PM
Ryasmeen reopened this task as Open.Sep 15 2016, 9:00 PM

Hmm, it again started failing for me. Reopening it.

• AlexMonk-WMF added a comment.Sep 16 2016, 12:02 AM

On test2 or in beta?

Paladox subscribed.Sep 16 2016, 12:08 AM

Ah yeh they rolled back wmf 19 back to wmf 18. We will need to back port that patch to wmf 19 and 18.

Ryasmeen added a comment.Sep 16 2016, 12:38 AM

Yeah, I am getting it on test2.

• AlexMonk-WMF added a comment.Sep 16 2016, 11:01 AM

If it can be reproduced in beta, let's keep this open. If it can be reproduced on non-testing production sites, we can probably backport it and deploy the fix today. Otherwise, let's close this and wait for test2wiki to receive the patch.

matmarex unsubscribed.Sep 17 2016, 2:16 PM
Jdforrester-WMF changed the task status from Open to Stalled.Sep 20 2016, 7:07 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.

This looks fixed to me in testing; @Ryasmeen, if you're happy please mark as Resolved, elsewise as Open.

Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptSep 20 2016, 7:07 PM
Ryasmeen closed this task as Resolved.EditedSep 20 2016, 9:31 PM

ok yeah, its not happening in Beta. So I guess we can mark it as Resolved. Will verify it when it lands on test2 since the bug was reported against that environment and was never happening on Beta for me.

Ryasmeen added a project: Verified-in-Phase0.Sep 22 2016, 9:22 PM
Ryasmeen added a project: Verified-in-Phase2.Sep 22 2016, 9:25 PM
Billinghurst moved this task from Backlog to Done: to deploy/check on the ProofreadPage board.Mar 5 2017, 2:04 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 5 2017, 2:04 AM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Mar 6 2017, 8:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL