Page MenuHomePhabricator
Create Task
Maniphest T145724

ProofreadPage parser tests are broken due to duplicate articles definitions
Closed, ResolvedPublic
Actions

Description

Tests for the <pages> and <pagelist> tags are both creating the same articles (mostly because article names should match conventions) and so fails because the 'ignoreduplicate' options have been removed (see T41473)

Details

SubjectRepoBranchLines +/-
Fixes ProofreadPage parser testsmediawiki/extensions/ProofreadPagemaster+194 -190
Removes duplicates articles creation in parser testsmediawiki/extensions/ProofreadPagemaster+346 -382
Initializes the zoom widget after page loadingmediawiki/extensions/ProofreadPagemaster+20 -8
Initializes the zoom widget after page loadingmediawiki/extensions/ProofreadPagewmf/1.28.0-wmf.18+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Tpt created this task.Sep 15 2016, 6:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2016, 6:33 AM
gerritbot subscribed.Sep 15 2016, 6:40 AM

Change 310738 had a related patch set uploaded (by Tpt):
Removes duplicates articles creation in parser tests

https://gerrit.wikimedia.org/r/310738

gerritbot added a project: Patch-For-Review.Sep 15 2016, 6:40 AM
Tpt mentioned this in T145790: Jenkins failures due to parser test failures.Sep 15 2016, 4:07 PM
• AlexMonk-WMF added a project: ProofreadPage.Sep 15 2016, 4:08 PM
Tpt added a comment.Sep 16 2016, 7:30 AM

DjVu support in parser tests seems broken too...

Tpt triaged this task as High priority.Sep 16 2016, 7:30 AM
Tpt added subscribers: • tstarling, Legoktm.
gerritbot added a comment.Sep 20 2016, 7:50 PM

Change 311769 had a related patch set uploaded (by Tpt):
Initializes the zoom widget after page loading

https://gerrit.wikimedia.org/r/311769

gerritbot added a comment.Sep 20 2016, 8:00 PM

Change 311777 had a related patch set uploaded (by Legoktm):
Initializes the zoom widget after page loading

https://gerrit.wikimedia.org/r/311777

gerritbot added a comment.Sep 20 2016, 8:02 PM

Change 311777 merged by jenkins-bot:
Initializes the zoom widget after page loading

https://gerrit.wikimedia.org/r/311777

gerritbot added a comment.Sep 20 2016, 8:07 PM

Change 311769 merged by Legoktm:
Initializes the zoom widget after page loading

https://gerrit.wikimedia.org/r/311769

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)), MW-1.28-release (WMF-deploy-2016-09-06_(1.28.0-wmf.18)).Sep 20 2016, 9:01 PM
AuFCL mentioned this in T145923: Need to reduce nsPage body edit box height in horizontal view.Sep 29 2016, 5:25 AM
Samwilson subscribed.Sep 29 2016, 5:31 AM
gerritbot added a comment.Oct 5 2016, 12:22 PM

Change 310738 merged by jenkins-bot:
Removes duplicates articles creation in parser tests

https://gerrit.wikimedia.org/r/310738

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 5 2016, 1:00 PM
gerritbot added a comment.Dec 24 2016, 6:18 PM

Change 329059 had a related patch set uploaded (by Tpt):
Fixes ProofreadPage parser tests

https://gerrit.wikimedia.org/r/329059

gerritbot added a comment.Dec 29 2016, 9:38 AM

Change 329059 merged by jenkins-bot:
Fixes ProofreadPage parser tests

https://gerrit.wikimedia.org/r/329059

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Dec 29 2016, 10:00 AM
Tpt closed this task as Resolved.Mar 27 2017, 4:14 PM
Tpt claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL