Missing libraries attribution in the app
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Josve05a
	Sep 15 2016, 10:35 AM

Description

Go to "about the app"
Press "Complete list" under "Libraries used"

Expected

See the list of libraries

Actual result

No libraries is shown

Device

iOS 10.0.1
iPhone 6s
5.2.0 (938)

--Testing--

load the app and tap the "gear" icon on the top left
tap the "About the app" item at the bottom of the Settings page
tap the "Complete list" link
when the list appears ensure it is not blank - it should be a fairly long list of libraries

Related Objects
Search...

Status	Assigned	Task
Open	None	T87268 Copyright license and attribution issues (tracking)
Invalid	None	T149179 Attribution and copyright tasks for the iOS app (tracking)
Open	None	T149184 [EPIC] License of the iOS app
Resolved	• JMinor	T145248 Release 5.2.0 (939)
Resolved	JoeWalsh	T145763 Missing libraries attribution in the app

Event Timeline

Josve05a created this task.Sep 15 2016, 10:35 AM

Restricted Application added subscribers: JEumerus, Aklapper. · View Herald TranscriptSep 15 2016, 10:35 AM

Josve05a added a parent task: T145248: Release 5.2.0 (939).Sep 15 2016, 10:36 AM

Josve05a added a project: User-Josve05a.

Josve05a added a parent task: T87268: Copyright license and attribution issues (tracking).

Josve05a moved this task from Backlog to Continue to complain about on the User-Josve05a board.

• JMinor triaged this task as High priority.Sep 19 2016, 6:26 PM

• JMinor merged a task: T145822: [Regression] Library credits no longer being autopopulted in About page.

• JMinor added a project: iOS-app-v5.3.0-Welsh-Dragon.

• JMinor subscribed.

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Sep 19 2016, 6:30 PM

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.3.0-Welsh-Dragon board.Sep 20 2016, 1:57 AM

Josve05a removed a parent task: T87268: Copyright license and attribution issues (tracking).Sep 20 2016, 8:10 PM

Josve05a edited projects, added Software-Licensing; removed WMF-Legal.

Josve05a added a project: Regression.

Josve05a moved this task from Backlog to Missing/unspecified license on the Software-Licensing board.

JoeWalsh claimed this task.Sep 21 2016, 2:19 PM

JoeWalsh moved this task from Ready for Development to Doing on the iOS-app-v5.3.0-Welsh-Dragon board.

JoeWalsh set the point value for this task to 1.

https://github.com/wikimedia/wikipedia-ios/pull/919

• Fjalapeno mentioned this in rAPIOS007b70a527b5: Merge pull request #919 from wikimedia/bug/missing_attribution/T145763.Sep 22 2016, 5:18 PM

JoeWalsh moved this task from Needs Code Review to Needs QA on the iOS-app-v5.3.0-Welsh-Dragon board.Sep 22 2016, 6:36 PM

JoeWalsh moved this task from Needs QA to Needs Testing Criteria on the iOS-app-v5.3.0-Welsh-Dragon board.

Mhurd updated the task description. (Show Details)Sep 22 2016, 7:09 PM

Mhurd moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.3.0-Welsh-Dragon board.

Device/app specs: iOS 10.0.1, iPhone 6s, app 5.2.1 (942). This has not been fixed yet in the current build so I moved it to the "Blocked or Waiting" section.

Nicholas.tsg moved this task from Needs QA to Blocked or Waiting on the iOS-app-v5.3.0-Welsh-Dragon board.Sep 22 2016, 9:22 PM

• JMinor mentioned this in T146083: Release 5.2.1 (942.1).Sep 22 2016, 10:56 PM

If we are using libraries which are under specific licenses, we should not keep releasing builds until they are attributed. To do so otherwise is a breach of licenses...and Wikipedia is more than articles, but a free content/information etc. and not attributing is a breach of our main pillar... /me sad

To be honest, I do not like that the previous build was released in the stores despite this.

Agreed. Thats why this ticket if marked High and was fixed first. It should be fixed in the internal channel later today.

Unfortunately this took a little effort to fix because of some major changes to our code structure to support iOS 10. Since 5.2.1 was already code complete and in testing when you found this, I decided not to pull the submission to fix this, but to make it our first priority for the next version.

• Fjalapeno moved this task from Blocked or Waiting to Needs Code Review on the iOS-app-v5.3.0-Welsh-Dragon board.Sep 27 2016, 6:23 PM

• Fjalapeno moved this task from Needs Code Review to Blocked or Waiting on the iOS-app-v5.3.0-Welsh-Dragon board.

• JMinor moved this task from Blocked or Waiting to Needs QA on the iOS-app-v5.3.0-Welsh-Dragon board.Sep 27 2016, 6:34 PM

Testing on iPad Air 2 (iOS 10.0.1) and Wikipedia build 5.3.0 (953). The libraries attribution looks fixed as shown in the screencap below.