Page MenuHomePhabricator

LivePreview "show changes" does not update or hide the category preview
Open, Needs TriagePublic

Description

Steps to reproduce:

Precondition: Activate LivePreview in preferences.

  • Edit a page and insert [[Category:Foo]]
  • Click on Show preview.
    • A spinner is shown.
    • A server interaction is done.
    • The spinner gets hidden.
    • The rendered preview and the preview of the categories are shown:

Category: Foo

  • Change content to [[Category:Bar]]
  • Click on Show changes.
    • A spinner is shown and the old previews get faded-out.
    • A server interaction is done.
    • The spinner gets hidden and the old previews get faded-in.
    • The new preview of the diff and but the old the preview of the categories are shown:

Category: Foo

Expected result:
The new preview of the categories are shown:

Category: Bar

Or alternative the preview of the categories get hidden.

The current situation is irritating because you expect no old values when you click on a show changes.

Event Timeline

Hmm, I guess we will not want to reveal the categories after a show changes call (like the non JS version).

Daimona claimed this task.
Daimona added a subscriber: Daimona.

Already fixed on MW master, following the repro steps in the task description. The categories are updated as expected (tried a few times in a row with different cats just to be sure).

Reopen. The behavior is unchanged. A click on Show changes doesn't update the categories on the bottom. There are still the categories from the first preview.
On disabled live preview a click on Show changes don't show any categories. This would be also a possible for live preview. But updated categories on Show changes would be nice.

Right, sorry, I got confused and tested this using "show preview" instead of "show changes".