This is just a non-strict equality error. Test for whether the CVV is present ($gotCVV in transactionConfirm_CreditCard) by strict comparison to "" and null. Nasty that empty("0") === true...
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Don't be fooled by CVV="0" | mediawiki/extensions/DonationInterface | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T117466 Q3 GOALS! (January-March) Keep at top of Q3 column | |||
| Resolved | None | T108229 [Epic] SPOF: Replace ActiveMQ donation queues with a more robust software stack | |||
| Resolved | None | T133108 [Epic] Rewrite all queue clients to use a single shim library, improve library | |||
| Resolved | awight | T133754 Upstream whatever we can to PHP-Queue | |||
| Resolved | awight | T133190 Remove KeyValueStore from PHP-Queue | |||
| Open | None | T134191 Write CiviCRM extension to view pending db records | |||
| Resolved | None | T130897 [Epic] Consolidate "pending" queue usages | |||
| Resolved | awight | T131275 [Epic] Move orphan rectifier out of payments | |||
| Resolved | awight | T141486 Rewrite orphan rectifier to use the pending database and WmfFramework | |||
| Resolved | awight | T145846 New orphan rectifier balks on CVV="0" |
Event Timeline
Comment Actions
Change 311098 had a related patch set uploaded (by Awight):
Don't be fooled by CVV="0"