FundraisingEmailUnsubscribe has broken git submodules
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Sep 16 2016, 10:31 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

gerritbot

Reedy

Description

Currently breaking code updates on beta:

10:23:02 INFO:mwextupdate:running: git submodule update --init --recursive
10:23:44 No submodule mapping found in .gitmodules for path 'vendor/coderkungfu/php-queue'
10:24:30 Failed to recurse into submodule path 'FundraisingEmailUnsubscribe'

And then locally

$ git submodule update --init --recursive
fatal: no submodule mapping found in .gitmodules for path 'vendor/coderkungfu/php-queue'

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Fix git submodule issue	Reedy	mediawiki/extensions/FundraisingEmailUnsubscribe	master	+9 -8
	Add .gitmodules for vendor/coderkungfu/php-queue	Reedy	mediawiki/extensions/FundraisingEmailUnsubscribe	master	+4 -0

Customize query in gerrit

Event Timeline

Reedy created this task.Sep 16 2016, 10:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2016, 10:31 AM

Change 311109 had a related patch set uploaded (by Reedy):
Add .gitmodules for vendor/coderkungfu/php-queue

https://gerrit.wikimedia.org/r/311109

gerritbot added a project: Patch-For-Review.Sep 16 2016, 10:42 AM

In T145859#2643242, @gerritbot wrote:

Change 311109 had a related patch set uploaded (by Reedy):
Add .gitmodules for vendor/coderkungfu/php-queue

https://gerrit.wikimedia.org/r/311109

It feels rather icky tbh. Registering a gitsubmodule for something brought in via composer...

Reedy added a project: Wikimedia-Fundraising.Sep 16 2016, 10:46 AM

Change 311112 had a related patch set uploaded (by Reedy):
Re-do I7c96ff

https://gerrit.wikimedia.org/r/311112

Change 311109 abandoned by Reedy:
Add .gitmodules for vendor/coderkungfu/php-queue

https://gerrit.wikimedia.org/r/311109

Change 311112 abandoned by Reedy:
Fix git submodule issue

https://gerrit.wikimedia.org/r/311112

Was fixed by https://github.com/wikimedia/mediawiki-extensions-FundraisingEmailUnsubscribe/commit/892ec48b1adf86fe24c7265792fab15d52c1ac2d

FundraisingEmailUnsubscribe has broken git submodulesClosed, ResolvedPublicActions

Description

Details

Event Timeline

FundraisingEmailUnsubscribe has broken git submodules
Closed, ResolvedPublic
Actions