Page MenuHomePhabricator
Create Task
Maniphest T145908

isWideScreen is not cached
Closed, ResolvedPublic
Actions

Description

It uses .innerWidth which can cause a reflow (because reasons).

Related Objects

Event Timeline

Esanders created this task.Sep 16 2016, 10:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2016, 10:22 PM
Esanders updated the task description. (Show Details)Sep 16 2016, 10:25 PM
Esanders added a subscriber: Catrope.
ori closed this task as Resolved.Sep 16 2016, 10:45 PM
ori claimed this task.
ori subscribed.

Done in b2b54c3437a1.

Esanders added a comment.Sep 17 2016, 4:25 PM

Does the cache need to be cleared if the device is rotated?

Esanders added a comment.Sep 17 2016, 5:29 PM

Ah, saw comment on https://gerrit.wikimedia.org/r/#/c/311199/ . This method just checks the aspect ratio of the device, regardless of orientation.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL