Page MenuHomePhabricator
Create Task
Maniphest T145970

JS things (like VE) fail to load if site's JS is broken (bypassable in debug mode)
Closed, ResolvedPublic
Actions

Description

he.wiki's js broke in T145967, the issue was local, but it showed a real issue in ve, it should not fail to load is the site's js is broken.

Details

SubjectRepoBranchLines +/-
Correct error handling for exceptions in 'user' modulemediawiki/coremaster+45 -42
Customize query in gerrit

Related Objects

Event Timeline

Matanya created this task.Sep 18 2016, 12:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2016, 12:18 PM
matmarex subscribed.Sep 18 2016, 12:29 PM
matmarex edited projects, added MediaWiki-ResourceLoader; removed VisualEditor.Sep 18 2016, 12:42 PM
matmarex added a subscriber: Krinkle.

VE does everything correctly, as far as I can see, I think this is a bug in ResourceLoader.

matmarex added a comment.Sep 18 2016, 12:50 PM

To reproduce: edit "MediaWiki:Group-user.js" on your wiki to cause an exception when it's executed (e.g. derp();), then try loading VE on any page in non-debug mode.

Running mw.loader.getState( 'user' ) in browser console returns "executing". That is very wrong. Presumably, in VE's code mw.loader.using( [ 'user', 'site' ] ) just waits forever, and the editor never loads.

gerritbot subscribed.Sep 18 2016, 12:59 PM

Change 311329 had a related patch set uploaded (by Bartosz Dziewoński):
Correct error handling for exceptions in 'user' module

https://gerrit.wikimedia.org/r/311329

gerritbot added a project: Patch-For-Review.Sep 18 2016, 12:59 PM
Jdforrester-WMF renamed this task from VE fails to load if site's js is broken, but only when not using debug mode to JS things (like VE) fail to load if site's JS is broken (bypassable in debug mode).Sep 19 2016, 5:41 PM
Jdforrester-WMF subscribed.

I'd have thought that this was already a task, but I can't find it.

matmarex added a comment.Sep 19 2016, 5:59 PM

It was broken and fixed at least once in the past, but I can't find the task either.

matmarex added a comment.Sep 21 2016, 8:07 PM

Hmm, the current description is not correct though. This only affects JS things that depend on the 'user' module.

gerritbot added a comment.Sep 22 2016, 9:14 PM

Change 311329 merged by Bartosz Dziewoński:
Correct error handling for exceptions in 'user' module

https://gerrit.wikimedia.org/r/311329

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)).Sep 22 2016, 10:00 PM
matmarex closed this task as Resolved.Sep 23 2016, 8:26 PM
matmarex claimed this task.
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL