Page MenuHomePhabricator

WikiForum doesn't parse the gallery tag from MediaWiki core correctly
Closed, ResolvedPublic

Description

Instead of the normal, grey boxes wrapped around images, it displays them as an up-to-down unordered (bulleted) list. Here's a screenshot:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2016, 9:04 PM
SamanthaNguyen moved this task from Backlog to Bugs on the WikiForum board.

It feels like there's some sort of stylesheet that isn't being loaded when it should be

Yeah, mediawiki.page.gallery.styles isn't being loaded. Loading it specifically isn't gonna be the best way of doing it as then it'll be loaded even when there's no gallery. Not sure what the best way is though.

Okay I've spent a while looking through the source trying to find when mediawiki.page.gallery is loaded, and can't, so I guess we'll just have to load it on every wikiforum page.

Change 329016 had a related patch set uploaded (by UltrasonicNXT):
Fix the displaying of galleries in forums

https://gerrit.wikimedia.org/r/329016

Change 329016 merged by jenkins-bot:
Fix the displaying of galleries in forums

https://gerrit.wikimedia.org/r/329016

SamanthaNguyen closed this task as Resolved.Dec 23 2016, 10:36 PM
SamanthaNguyen removed a project: Patch-For-Review.

(from chat, here so I remember it) I guess you could hook in, then check the page title, and if it's wikiforum, load the module. Such effort though

BeforeParserrenderImageGallery would be the one

@UltrasonicNXT Should this still be marked as RESOLVED, or should this be re-opened?

mmm well resolved as it's fixed, there just may be a better way of doing it.