Page MenuHomePhabricator

DeepSea submenus should use relative URL paths, along with $wgArticlePath
Closed, DeclinedPublic

Description

Offending line: https://github.com/wikimedia/mediawiki-skins-DeepSea/blob/master/DeepSea.skin.php#L519

Currently, these URLs are specific to brickimedia, they should switch to relative URL paths for efficiency. Basically instead of the full URL, we could use a slash with the $wgArticlePath.

Related Objects

Event Timeline

SamanthaNguyen moved this task from Backlog to Feedback on the DeepSea board.
SamanthaNguyen moved this task from Backlog to DeepSea on the Brickimedia board.

I fully agree. The problem is that I'm not sure how to best handle this -- should we introduce a new hook and write a mini-extension to hook into that hook to preserve the current behavior, should we just ditch the current behavior or something else? The catch here is the $bmProjectsData array (as well as the Brickimedia-specific $bmProject global which is set in Brickimedia's LocalSettings files, but obviously not set for non-Brickimedia projects) -- see line 495 onwards. Basically the code iterates over the $bmProjectsData array (which currently has only two items) and creates these links (my talk page, forum, chat, etc.) for all/both sites (en and gbc). This means that it's not possible to both fix this bug and preserve the current behavior; but out of those choices, I'd prefer fixing this bug.