Page MenuHomePhabricator

redisJobRunnerService uses sh to run curl commands and shows defunct sh process
Closed, DeclinedPublic

Description

Spotted on mw1299:

146477 ?        Ss    86:02  \_ /usr/bin/php /srv/deployment/jobrunner/jobrunner/redisJobRunnerService --config-file=/etc/jobrunner/jobrunner.conf 
105325 ?        Z      0:00  |   \_ [sh] <defunct>
105326 ?        Z      0:00  |   \_ [sh] <defunct>
105328 ?        Z      0:00  |   \_ [sh] <defunct>
105331 ?        Z      0:00  |   \_ [sh] <defunct>
105333 ?        Z      0:00  |   \_ [sh] <defunct>
112244 ?        Z      0:00  |   \_ [sh] <defunct>
112256 ?        S      0:00  |   \_ sh -c curl -XPOST -s -a 'http://127.0.0.1:9005/rpc/RunJobs.php?wiki=arwiki&type=flaggedrevs_CacheUpdate&maxtime=60&maxmem=300M'
112259 ?        S      0:00  |   |   \_ curl -XPOST -s -a http://127.0.0.1:9005/rpc/RunJobs.php?wiki=arwiki&type=flaggedrevs_CacheUpdate&maxtime=60&maxmem=300M
112308 ?        S      0:00  |   \_ sh -c curl -XPOST -s -a 'http://127.0.0.1:9005/rpc/RunJobs.php?wiki=viwiki&type=refreshLinksPrioritized&maxtime=60&maxmem=300M'
112313 ?        S      0:00  |   |   \_ curl -XPOST -s -a http://127.0.0.1:9005/rpc/RunJobs.php?wiki=viwiki&type=refreshLinksPrioritized&maxtime=60&maxmem=300M

We should probably execute the curl command without a shell. Not sure what is the need of the sh overhead, but maybe there is. If needed, might want to look at why some sh are zombie for sometime.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2016, 3:27 PM
hashar triaged this task as Normal priority.Oct 6 2016, 3:09 PM
Krinkle moved this task from Untriaged to Legacy infra on the WMF-JobQueue board.Jul 11 2018, 3:03 AM
Krinkle closed this task as Declined.Jul 11 2018, 3:05 AM
Krinkle added a subscriber: Krinkle.

Closing out as this seems specific to the old Redis-based JobQueue and JobRunner that are no longer as of last week. Please re-open if it still applies.

(See T198220 and T157088)