Regression: Tracker in Text-resize is twice as thick as expected.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Sep 20 2016, 10:53 AM

Description

In T126688#2191567, @RHo wrote:

Tracker and tick marks are twice as thick as they should be (per Nirzar's previous comment)

Expected: tracker height and tick mark width should be 1px

Actual: tracker height and tick mark width are 2px

Related Objects

Mentioned In: rAPIOS029811c6688b: Merge pull request #949 from wikimedia/bug/text-resizer-line-thickness/T146137
Mentioned Here: T126688: Dynamic text size control for articles in iOS app

Event Timeline

RHo created this task.Sep 20 2016, 10:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2016, 10:53 AM

• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.Sep 20 2016, 7:44 PM

• JMinor triaged this task as Low priority.Oct 3 2016, 11:18 PM

• JMinor added a project: iOS-app-v5.3.0-Welsh-Dragon.

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.3.0-Welsh-Dragon board.

Mhurd claimed this task.Oct 8 2016, 4:30 AM

Mhurd moved this task from Ready for Development to Needs Code Review on the iOS-app-v5.3.0-Welsh-Dragon board.

https://github.com/wikimedia/wikipedia-ios/pull/949

• Fjalapeno mentioned this in rAPIOS029811c6688b: Merge pull request #949 from wikimedia/bug/text-resizer-line-thickness/T146137.Oct 11 2016, 2:30 PM

• Fjalapeno moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 11 2016, 6:04 PM

Testing steps:

Load any article
Tap the text size adjustment icon on the toolbar at the bottom of the article
When the text size slider appears look at the horizontal line and ensure it is thin

Here's how it looked before (tap to enlarge):

Here's how it should look now (tap to enlarge):

Mhurd moved this task from Needs Testing Criteria to Needs Design Review on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 11 2016, 8:09 PM

@RHo should be good to go for design review

LGTM

Simulator Screen Shot Oct 12, 2016, 8.22.18 PM.png (1×750 px, 660 KB)

Testing Wikipedia app 5.3.0 (958) on iPhone (iOS 10.0.2). According to the screencap below which compares the slider in the iPhone settings with the slider in the app, the tracker height and tick mark width are still 2p in the app.

Comparisons of tracker height - tick mark.PNG (1×640 px, 200 KB)

Nicholas.tsg moved this task from Needs QA to Blocked or Waiting on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 12 2016, 9:49 PM

• JMinor moved this task from Blocked or Waiting to Ready for PM Signoff on the iOS-app-v5.3.0-Welsh-Dragon board.Oct 18 2016, 6:36 PM

This was tested before the fix was pushed to test flight. Verified this is fixed in the current beta.

• JMinor closed this task as Resolved.Oct 25 2016, 10:22 PM

	F4597940: Comparisons of tracker height - tick mark.PNG
	Oct 12 2016, 9:49 PM

	F4597271: Simulator Screen Shot Oct 12, 2016, 8.22.18 PM.png
	Oct 12 2016, 6:23 PM

Regression: Tracker in Text-resize is twice as thick as expected. Closed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Regression: Tracker in Text-resize is twice as thick as expected.
Closed, ResolvedPublic
Actions