Page MenuHomePhabricator

UploadWizard warns of properly filling gin all the fields; isn't clear which fields it wants
Closed, ResolvedPublic


When using the UploadWizard on Wikimedia Commons I received a warning dialog when interacting with the final "Next" before uploading the file.

Screen Shot 2016-09-20 at 9.44.10 AM.png (214×337 px, 26 KB)

I filled out the three required fields (Title, Description, and Date) and then pressed "Next"

It is hard to see that there is now a small indicator that the "Categories" field is recommended. The Warning dialog overlays most of the form (and fades it out). The appearance of the field recommendation happens at the same time as the dialog appearing (where my focus is at), and the recommendation itself is not distinguished from other field labels (set in the same font, weight, etc. as other field indicators).

Screen Shot 2016-09-20 at 10.02.40 AM.png (103×677 px, 13 KB)

Steps to reproduce

  1. Visit
  2. Select media and press "Continue"
  3. Select a license and then press "Next"
  4. Fill out the Title, Description, and Date Fields
  5. Press "Next"
  6. Receive one confusing dialog

Expected behavior
If I fill out the required fields the form should submit. Having a 3rd state (recommended) adds an unclear response to submitting the form.

If an upload is missing a recommended field there should be a more obvious indication as to which field is being requested.
"We recommend you fill in the "X" field(s)."

See the dialog for one of the required fields as an example. The icon provides a clear indication that this is the field. The icon is different from the other 'information' icons on the form. (Note that we're reusing the "information" icon in this form - one that is consistent between fields (and interactive), one that is not.

Screen Shot 2016-09-20 at 10.00.07 AM.png (97×413 px, 14 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 311982 had a related patch set uploaded (by Matthias Mullie):
Display warnings in confirmation window

Change 311982 merged by jenkins-bot:
Display warnings in confirmation window

If I fill out the required fields the form should submit. Having a 3rd state (recommended) adds an unclear response to submitting the form.

I don't think we should remove the warnings in general. UploadWizard is expected to provide some guidance for new users, and categories are indeed recommended – I think the only reason they're not required is because the category system is poor and it's possible to actually not find anything relevant. We have other ones too that are probably more useful than this one anyway.

matmarex removed a project: Patch-For-Review.

After the change:

pasted_file (950×1 px, 94 KB)

I'll mark this as resolved. See T145674 for discussion about the design of the warning labels near the field.