Page MenuHomePhabricator

NWE should let you edit talk pages, templates, and JSON blobs, (but not let you switch)
Closed, ResolvedPublic8 Story Points

Description

The namespace and content model checks in init.isAvailable should only apply to VE, not NWE, and we should disable the switch button in such circumstances. Not sure how to factor out it from the rest neatly.

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedEsanders
OpenNone
OpenNone
ResolvedJules78120
OpenNone
ResolvedDannyH
OpenNone
OpenEsanders
OpenNone
OpenEsanders
ResolvedJdforrester-WMF
Resolved AlexMonk-WMF

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2016, 6:27 PM
Techbby renamed this task from NWE should let you edit talk pages, templates, and JSON blobs, (but not let you switch) to Outreachy proposal for project task.Sep 20 2016, 10:19 PM
Techbby claimed this task.
Techbby removed subscribers: Jdforrester-WMF, Aklapper.
AlexMonk-WMF renamed this task from Outreachy proposal for project task to NWE should let you edit talk pages, templates, and JSON blobs, (but not let you switch).Sep 20 2016, 10:26 PM
AlexMonk-WMF removed Techbby as the assignee of this task.

Change 311860 had a related patch set uploaded (by Alex Monk):
Split isAvailable from visual-specific checks

https://gerrit.wikimedia.org/r/311860

Change 311860 merged by jenkins-bot:
Split isAvailable from visual-specific checks

https://gerrit.wikimedia.org/r/311860

This first half of this is done, but the switch button needs to be disabled where isAvailable is true but isVisualAvailable isn't.

Change 312618 had a related patch set uploaded (by Alex Monk):
NWE: Don't show button to switch to VE if it isn't available

https://gerrit.wikimedia.org/r/312618

Change 312618 merged by jenkins-bot:
NWE: Don't show button to switch to VE if it isn't available

https://gerrit.wikimedia.org/r/312618

Change 313908 had a related patch set uploaded (by Alex Monk):
Allow NWE on non-VE namespaces

https://gerrit.wikimedia.org/r/313908

Change 314040 had a related patch set uploaded (by Alex Monk):
Disable switch-to-VE button in NWE if VE is unavailable, don't hide it

https://gerrit.wikimedia.org/r/314040

Change 313908 merged by jenkins-bot:
Allow NWE on non-VE namespaces

https://gerrit.wikimedia.org/r/313908

Change 314040 merged by jenkins-bot:
Disable switch-to-VE button in NWE if VE is unavailable, don't hide it

https://gerrit.wikimedia.org/r/314040

Jdforrester-WMF closed this task as Resolved.Oct 5 2016, 6:33 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.