Page MenuHomePhabricator
Create Task
Maniphest T146190

VE Gallery editor adds a description called Undefined when editing some galleries
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

VE Gallery editor adds a description called Undefined when editing very large galleries e.g

https://commons.wikimedia.org/w/index.php?title=User:John_Cummings/Biosphere_Reserve_best_images&oldid=207254358

Details

SubjectRepoBranchLines +/-
Handle missing pipes in Gallery syntax, and remove them when caption is emptymediawiki/extensions/VisualEditormaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

John_Cummings created this task.Sep 20 2016, 6:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 20 2016, 6:55 PM
Jdforrester-WMF triaged this task as Medium priority.Oct 4 2016, 7:16 PM
Jdforrester-WMF added projects: MediaWiki-Gallery, VisualEditor-MediaWiki-Media.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF added a subscriber: Tchanders.
Esanders subscribed.EditedNov 19 2016, 2:07 PM

Looks like the same as T147067

Esanders added a comment.Nov 19 2016, 2:40 PM

I think this is due the regex returning Undefined when there is no pipe after the filename. We should normalise that to an empty string, and we should also not render a pipe if there is no caption on save.

Esanders renamed this task from VE Gallery editor adds a description called Undefined when editing very large galleries to VE Gallery editor adds a description called Undefined when editing some galleries.Nov 28 2016, 5:16 PM
gerritbot subscribed.Nov 28 2016, 5:37 PM

Change 323858 had a related patch set uploaded (by Esanders):
Handle missing pipes in Gallery syntax, and remove them when caption is empty

https://gerrit.wikimedia.org/r/323858

gerritbot added a project: Patch-For-Review.Nov 28 2016, 5:37 PM
Jdforrester-WMF closed this task as Resolved.Nov 29 2016, 7:17 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Nov 29 2016, 7:27 PM

Change 323858 merged by jenkins-bot:
Handle missing pipes in Gallery syntax, and remove them when caption is empty

https://gerrit.wikimedia.org/r/323858

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Nov 29 2016, 8:00 PM
Jdforrester-WMF mentioned this in T151992: Editing a gallery without "File:" prefixes throws JS error in VE.Nov 30 2016, 4:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL