Page MenuHomePhabricator
Create Task
Maniphest T146231

Align Wikimedia Portal UI elements to improved color palette
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Volker_E
Sep 20 2016, 11:07 PM
Tags
Referenced Files
F4669568: language-ltr.svg
Oct 28 2016, 9:14 AM
F4669569: language-rtl.svg
Oct 28 2016, 9:14 AM
F4586089: Screen Shot 2016-10-11 at 10.37.42 AM.png
Oct 11 2016, 4:40 PM
Subscribers
Aklapper
debt
• Deskana
gerritbot
Jdrewniak
• JGirault
• Nirzar
View All 10 Subscribers

Description

As we now have a broadly agreed-on, WCAG compliant color palette M82, we should make use of it in Wikimedia Portal UI elements as well.

Details

SubjectRepoBranchLines +/-
Align leftover colors to overhauled color palettewikimedia/portalsmaster+21 -26
Align remaining colors to color palette and update WMUI base variableswikimedia/portalsmaster+123 -96
Updating language icon colorwikimedia/portalsmaster+1 K -1 K
Align UI elements to improved WCAG compliant color palettewikimedia/portalsmaster+327 -246
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Sep 20 2016, 11:07 PM
Restricted Application added projects: Discovery-ARCHIVED, UI-Standardization. · View Herald TranscriptSep 20 2016, 11:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Sep 21 2016, 12:17 AM

Change 311879 had a related patch set uploaded (by VolkerE):
Align UI elements to improved WCAG compliant color palette

https://gerrit.wikimedia.org/r/311879

gerritbot added a project: Patch-For-Review.Sep 21 2016, 12:17 AM
Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.Sep 21 2016, 12:19 AM
gerritbot added a comment.Sep 23 2016, 3:39 PM

Change 311879 merged by jenkins-bot:
Align UI elements to improved WCAG compliant color palette

https://gerrit.wikimedia.org/r/311879

debt added a project: Discovery-Portal-Sprint.Sep 27 2016, 6:34 PM
debt moved this task from Backlog to Done on the Discovery-Portal-Sprint board.
debt added a comment.Oct 11 2016, 4:40 PM

This was released into production on Oct 11, 2016 during morning SWAT - brightening up the text blue color (see this ticket).

Screen Shot 2016-10-11 at 10.37.42 AM.png (534×593 px, 93 KB)

debt closed this task as Resolved.Oct 11 2016, 8:52 PM
debt triaged this task as Medium priority.
Volker_E reopened this task as Open.Oct 11 2016, 9:29 PM
Volker_E removed a project: Patch-For-Review.

Great progress! :)
But we're still missing the correct blue on the language icon from the language dropdown.

debt moved this task from Done to What's Next on the Discovery-Portal-Sprint board.Oct 12 2016, 7:32 PM

Whoops!

Volker_E added a comment.Oct 28 2016, 12:50 AM

@Jdrewniak Reassigning the task as I don't have the source file for the sprite.

Volker_E reassigned this task from Volker_E to Jdrewniak.Oct 28 2016, 12:50 AM
Volker_E moved this task from Review to Backlog on the UI-Standardization-Kanban board.Oct 28 2016, 2:29 AM
Pginer-WMF added a comment.Oct 28 2016, 9:14 AM

The language icon is part of the oojs icon repo (if you have it locally, it is "obviously" at src/themes/mediawiki/images/icons/ ):

I'd expect SVGs to be used (with png fallback) for the benefit of those with high resolution displays.

Volker_E added a comment.Oct 28 2016, 6:05 PM

Just to be precise, we've got the language icon and the bookshelf in a different shade of blue. I don't even know where the bookshelf is in use right now.

Volker_E moved this task from Backlog to Current Goals (tracking) on the UI-Standardization-Kanban board.Oct 28 2016, 9:15 PM
Volker_E added a subscriber: • JGirault.Nov 8 2016, 12:00 AM

@JGirault pointed me to the original bookshelf SVGs https://commons.wikimedia.org/wiki/File:Bookshelf-40x20.svg and https://commons.wikimedia.org/wiki/File:Bookshelf-40x20_blue.svg

gerritbot added a comment.Nov 10 2016, 12:12 PM

Change 320761 had a related patch set uploaded (by Jdrewniak):
Updating language icon color

https://gerrit.wikimedia.org/r/320761

gerritbot added a project: Patch-For-Review.Nov 10 2016, 12:12 PM
Jdrewniak added a comment.Nov 10 2016, 12:39 PM

@Volker_E The patch mentioned above changes the language icon color to the M82 blue (#3366cc).
https://gerrit.wikimedia.org/r/#/c/320761/1/prod/wikipedia.org/assets/img/sprite-bookshelf_icons%25402x.png,unified

(I also removed the bookshelf icon, but don't tell anyone... )

Volker_E added a comment.Nov 16 2016, 1:14 AM

@Jdrewniak There's one more occasion of the old blue in _survey-banner.css. I don't get if it's still in use anymore – haven't we spoken about it getting removed anyways before?

Volker_E moved this task from Current Goals (tracking) to Doing… on the UI-Standardization-Kanban board.Nov 16 2016, 6:52 PM
gerritbot added a comment.Nov 16 2016, 10:41 PM

Change 320761 merged by jenkins-bot:
Updating language icon color

https://gerrit.wikimedia.org/r/320761

Volker_E added a comment.Nov 17 2016, 2:14 AM

Follow-up on the survey-banner leftovers: https://gerrit.wikimedia.org/r/#/c/322036/

Volker_E added a parent task: T148708: Replace abandoned colors in current WMF/Wikimedia products with WikimediaUI palette colors (tracking).Nov 20 2016, 2:50 AM
gerritbot added a comment.Nov 22 2016, 7:10 AM

Change 322831 had a related patch set uploaded (by VolkerE):
Align remaining colors to color palette and update WMUI base variables

https://gerrit.wikimedia.org/r/322831

gerritbot added a comment.Nov 29 2016, 3:34 PM

Change 322831 merged by jenkins-bot:
Align remaining colors to color palette and update WMUI base variables

https://gerrit.wikimedia.org/r/322831

Volker_E closed this task as Resolved.Nov 29 2016, 3:37 PM
Volker_E removed a project: Patch-For-Review.
Volker_E moved this task from Doing… to Done on the UI-Standardization-Kanban board.Nov 29 2016, 3:40 PM
debt mentioned this in T144834: Wikipedia.org Portal: update logo for new branding guidelines.Nov 29 2016, 4:38 PM
Volker_E reopened this task as Open.Dec 2 2016, 10:05 PM
Volker_E added a comment.EditedDec 2 2016, 10:12 PM

In a further search, there has also been the CSS rgb( 52, 123, 255 ) notation of the old blue #347bff used (luckily just in the portal). Therefore we need to reopen this one more time.

gerritbot added a comment.Dec 2 2016, 11:29 PM

Change 325057 had a related patch set uploaded (by VolkerE):
Align leftover colors to overhauled color palette

https://gerrit.wikimedia.org/r/325057

gerritbot added a project: Patch-For-Review.Dec 2 2016, 11:29 PM
Volker_E moved this task from Done to Review on the UI-Standardization-Kanban board.Dec 2 2016, 11:33 PM
gerritbot added a comment.Dec 5 2016, 7:38 PM

Change 325057 merged by jenkins-bot:
Align leftover colors to overhauled color palette

https://gerrit.wikimedia.org/r/325057

Volker_E closed this task as Resolved.Dec 5 2016, 8:07 PM
Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.
debt moved this task from What's Next to Done on the Discovery-Portal-Sprint board.Mar 22 2017, 3:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL