Page MenuHomePhabricator
Create Task
Maniphest T146249

MobileFrontend disable images doesn't disable maps
Closed, DeclinedPublic
Actions

Description

In mobile interface under "Settings" there is option for disable images. The option doesn't disable maps (created by Kartographer extension)

How to reproduce:

  1. Go to some page with map with mobile client (example https://he.m.wikipedia.org/wiki/%D7%95%D7%99%D7%91%D7%95_%D7%95%D7%9C%D7%A0%D7%98%D7%99%D7%94 )
  2. Goto to settings and validate images are disabled
  3. Back to the page and validate

Expected: Map SHOULD not be shown (some other placeholder MAY show "Here is a map of <coords>")
Actual: Map appears

Related Objects
Search...

Event Timeline

eranroz created this task.Sep 21 2016, 4:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2016, 4:04 AM
Anomie removed a project: Reading-Infrastructure-Team-Old (Don't use).Sep 21 2016, 2:44 PM
Jdlrobson subscribed.Sep 21 2016, 5:39 PM

It's worth noting, given the lazy images change we introduced I'm quite keen for us to remove the disable images functionality (this should be handled on the browser level imo).

The existing implementation is specific to MobileFrontend only and is very limited in that it doesn't disable the loading of images via CSS/JS (note the talk icon) and the implementation is not seamless when it comes to other extensions (RelatedArticles has same issue).

MBinder_WMF added a project: Web-Team-Backlog.Sep 22 2016, 5:17 PM
MaxSem subscribed.Sep 23 2016, 7:39 AM

@Jdlrobson, so this is a wontfix?

Jdlrobson added a comment.Sep 23 2016, 11:19 PM

Depends. That decision hasn't been made yet. You probably want to track T109870

Yurik added projects: Maps, Maps-Sprint.Sep 27 2016, 9:05 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptSep 27 2016, 9:05 PM
Yurik added a parent task: T109870: Remove the Disable images functionality.Oct 12 2016, 6:38 PM
Yurik removed a project: Maps-Sprint.
ovasileva moved this task from Incoming to Product Owner Backlog on the Web-Team-Backlog board.Nov 2 2016, 8:02 PM
Jdlrobson changed the task status from Open to Stalled.Dec 13 2016, 5:43 PM
• bmansurov subscribed.Dec 13 2016, 5:54 PM

We should also note that disabling images at the browser level has its downsides too. For example, the hamburger menu icon won't show, while it would if we disabled images using a setting like we do now.

Yurik removed a project: Maps.Dec 15 2016, 4:39 AM
Jdlrobson removed a project: MobileFrontend.May 21 2017, 12:13 PM
Jdlrobson removed a project: Web-Team-Backlog.
phuedx closed this task as Declined.Jun 20 2017, 10:31 AM
phuedx subscribed.

All of the changes for T109870: Remove the Disable images functionality have been merged and it's now in QA (and will likely be signed off soon after). We've made the decision to remove the feature, though not necessarily explicitly.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL