Page MenuHomePhabricator

DatabaseMysqlBase::tableExists() ignores tablePrefix
Closed, ResolvedPublic

Description

rMW4e4b9997493c: Improve tableExists() for MySQL introduced a more optimized tableExists() method for MySQL, but the function introduced does not honor the configured tablePrefix. This caused various unit tests to start failing, e.g. https://gerrit.wikimedia.org/r/311270, https://gerrit.wikimedia.org/r/311514, https://gerrit.wikimedia.org/r/311515, because the "unittest_" prefix was not being included when things were testing for the unit test tables.

Event Timeline

Anomie created this task.Sep 21 2016, 3:43 PM

Change 312018 had a related patch set uploaded (by Anomie):
Add table prefix in new MySQL tableExists()

https://gerrit.wikimedia.org/r/312018

Change 312018 merged by jenkins-bot:
Add table prefix in new MySQL tableExists()

https://gerrit.wikimedia.org/r/312018

Anomie closed this task as Resolved.Sep 21 2016, 4:18 PM

Hmm. The errors being logged (at least for CentralAuth) changed with the fix of this bug, but didn't entirely go away.