Page MenuHomePhabricator

LqtView::postEditUpdates still used in import-parsed-discussions.php
Closed, ResolvedPublic

Description

When doing T145736, I noticed LqtView::postEditUpdates is still used

Needs migrating to one of the utility functions, passing an array instead of loads of parameters

Event Timeline

Reedy created this task.Sep 21 2016, 8:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2016, 8:09 PM
Reedy triaged this task as Lowest priority.Sep 21 2016, 8:09 PM

Change 599806 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/LiquidThreads@master] Fix import-parsed-discussions.php script broken since 2009

https://gerrit.wikimedia.org/r/599806

The method was removed in 2009:

Looking at these diffs, I realized a replacement is much more straightforward than expected. We can just follow the similar replacements done in this patch. So did I in https://gerrit.wikimedia.org/r/599806.

Change 604424 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/LiquidThreads@master] Delete import-parsed-discussions.php broken since 2009

https://gerrit.wikimedia.org/r/604424

Change 599806 abandoned by DannyS712:
Fix import-parsed-discussions.php script broken since 2009

Reason:
Script being removed entirely instead - I65a42ee864096ff5e39aa379eb15ea8f5cd1f077

https://gerrit.wikimedia.org/r/599806

Change 604424 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Delete import-parsed-discussions.php broken since 2009

https://gerrit.wikimedia.org/r/604424

DannyS712 closed this task as Resolved.Jun 13 2020, 5:34 AM
DannyS712 assigned this task to thiemowmde.
DannyS712 removed a project: Patch-For-Review.