Page MenuHomePhabricator

[regression-betalabs] Notifications from deleted topic displayed on Special:Notifications page and in the notification panel
Closed, ResolvedPublic

Description

  1. In the notification panel and on Special:Notificaitons page, the notifications from deleted topics are still displayed (at least, new topic notifications)
  2. The topic titles of deleted topics are displayed as "*"

Screen Shot 2016-09-21 at 1.58.41 PM.png (296×703 px, 50 KB)

Screen Shot 2016-09-21 at 1.59.28 PM.png (483×1 px, 71 KB)

  1. Clicking on the notification will redirect to https://en.wikipedia.beta.wmflabs.org/wiki/Topic:T62j5f7g7h48d15k

Screen Shot 2016-09-21 at 2.12.02 PM.png (365×1 px, 58 KB)

  1. In foreign wiki, the above notice will be bundle, e.g.

Screen Shot 2016-09-21 at 2.15.35 PM.png (403×637 px, 54 KB)

Clicking on the bundle (as a primary link), a user will re-directed to https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:ET60&topiclist_sortby=newest, which of course, won't have any of those topics since they were deleted.

Event Timeline

I just retested all the scenarios: (topic, post) x (delete, suppress, restore) and I found no problems.

It looks like moderation was broken between Sept 12 (https://gerrit.wikimedia.org/r/#/c/310063) and Sept 19 (https://gerrit.wikimedia.org/r/#/c/311653/). It affected wmf-19 during that time. I don't know if it ever hit production given the recent deployment problems.

Let me know if there's something else there and you can still reproduce the problem.

Thanks, @SBisson - seems that all is fine now.
Re-checked in betalabs - deleting topic clears all notificaitons as expected.