Page MenuHomePhabricator
Create Task
Maniphest T146398

Create Mobile content service endpoint for references
Closed, ResolvedPublic
Actions

Description

As an API consumer I want an API query which returns just the references of a page
e.g.
https://en.wikipedia.org/api/rest_v1/page/mobile-sections-references/San%20Francisco

Any section which has the class mw-references in it would be served by the endpoint in a sections array
If no references are available for a page the array will be empty.

Given revision id is important when determining references, we will also need to expose this and all other endpoints on a revision basis.

e.g.
https://en.wikipedia.org/api/rest_v1/revision/mobile-sections-references/<revid>

Details

SubjectRepoBranchLines +/-
Expose references in a new endpointmediawiki/services/mobileappsmaster+43 -0
Mark reference sections with isReferenceSection flagmediawiki/services/mobileappsmaster+78 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 22 2016, 6:07 PM
• bearND renamed this task from Create Mobile content service endpoint to Create Mobile content service endpoint for references.Sep 24 2016, 12:17 AM
• bearND moved this task from Incoming to Backlog on the Mobile-Content-Service board.
Jdlrobson updated the task description. (Show Details)Sep 27 2016, 11:00 PM
Jdlrobson added a subscriber: • bearND.

@bearND we should start a converstion around a new set of endpoints which support this use case and the breaking changes I've proposed in Gerrit.

Would you be able to help that conversation start or would you rather I just started submitting patches?

gerritbot subscribed.Sep 27 2016, 11:51 PM

Change 313149 had a related patch set uploaded (by Jdlrobson):
Mark reference sections with isReferenceSection flag

https://gerrit.wikimedia.org/r/313149

gerritbot added a project: Patch-For-Review.Sep 27 2016, 11:51 PM

Change 313150 had a related patch set uploaded (by Jdlrobson):
WIP: Expose references in a new endpoint

https://gerrit.wikimedia.org/r/313150

Jdlrobson mentioned this in T146836: Revision support broken in MCS.Sep 27 2016, 11:53 PM
• bearND added a comment.Sep 28 2016, 9:31 PM
In T146398#2672434, @Jdlrobson wrote:

@bearND we should start a converstion around a new set of endpoints which support this use case and the breaking changes I've proposed in Gerrit.

Would you be able to help that conversation start or would you rather I just started submitting patches?

Yes, I just created task T146944 to discuss this, which could also act as another parent of this and similar tasks. We can also have a quick chat if you prefer.

This doesn't preclude you from submitting more patches/specs. They provide concrete ideas on how you'd want a new version to look like.
I would like to know from you mainly what the time frame is when you would like to consume the new version/endpoints in mobile web.

• bearND moved this task from Backlog to Mobile-sections 2.0 on the Mobile-Content-Service board.Sep 28 2016, 10:06 PM
Jdlrobson moved this task from Mobile-sections 2.0 to Backlog on the Mobile-Content-Service board.Sep 28 2016, 10:09 PM

This particular one is backwards compatible, so not sure if you want to include it under "Mobile-sections 2.0"

gerritbot added a comment.Oct 12 2016, 11:08 PM

Change 313149 merged by jenkins-bot:
Mark reference sections with isReferenceSection flag

https://gerrit.wikimedia.org/r/313149

gerritbot added a comment.Oct 12 2016, 11:16 PM

Change 313150 merged by jenkins-bot:
Expose references in a new endpoint

https://gerrit.wikimedia.org/r/313150

• bearND moved this task from Backlog to To Deploy on the Mobile-Content-Service board.Oct 12 2016, 11:16 PM
• bearND moved this task from To Deploy to Mobile-sections 2.0 on the Mobile-Content-Service board.Oct 12 2016, 11:25 PM
• bearND moved this task from Mobile-sections 2.0 to To Deploy on the Mobile-Content-Service board.
• bearND added a parent task: T146944: Mobile-sections replacement.
• bearND closed this task as Resolved.Oct 18 2016, 7:30 PM
• bearND claimed this task.

Deployed as deploy/2016-10-17/e3d3d86

• Fjalapeno edited parent tasks, added: T170690: Extract a References JSON API; removed: T146944: Mobile-sections replacement, T146396: Improve performance of mobile references API.Oct 4 2017, 5:51 PM
Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptOct 4 2017, 5:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL