Page MenuHomePhabricator

Failed ExternalData requests result in all maps on page being completely broken
Closed, ResolvedPublic

Description

Repro: add several mapframes and maplinks to the page, make one of mapframes ingest shapes via ExternalData. Make the geoshapes request fail (the easiest way is to hack modules/box/Map.js and replace uri.path = '/geoshape' with something nonexistent).

All maps, including ones displayed by maplinks, appear blank.

Expected: a more graceful failure where tiles are still shown.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 314730 had a related patch set uploaded (by JGirault):
Refactor data loader into a separate lib

https://gerrit.wikimedia.org/r/314730

Change 314730 merged by Yurik:
Refactor data loader into a separate lib

https://gerrit.wikimedia.org/r/314730