Fix NewUserMessage getContent concatenation
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	• Mattflaschen-WMF
	Sep 22 2016, 7:55 PM

Description

Per @Legoktm at T145740:

"Also I note that some of this code is totally broken??"

		if ( $flags & EDIT_UPDATE ) {
			$text = $wikiPage->getContent( Revision::RAW ) . "\n" . $text;
		}

Only affects the edit path, which by definition should be rare (New UserMessage), nevertheless a bug.

Details

	Subject	Repo	Branch	Lines +/-
	Use MessagePoster for non-wikitext pages, fix two bugs	mediawiki/extensions/NewUserMessage	master	+399 -22

Customize query in gerrit

Related Objects

Mentioned In: T145740: NewUserMessage should not call WikiPage::doEdit()
Mentioned Here: T145740: NewUserMessage should not call WikiPage::doEdit()

Event Timeline

• Mattflaschen-WMF created this task.Sep 22 2016, 7:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2016, 7:55 PM

• Mattflaschen-WMF mentioned this in T145740: NewUserMessage should not call WikiPage::doEdit().Sep 22 2016, 7:55 PM

Change 310484 had a related patch set uploaded (by Mattflaschen):
Use MessagePoster for non-wikitext pages, fix two bugs

https://gerrit.wikimedia.org/r/310484

gerritbot added a project: Patch-For-Review.Sep 22 2016, 8:18 PM

Removing @Mattflaschen-WMF as task assignee to avoid cookie-licking.
(Matt, if you still like/plan to work on this, feel very welcome to re-claim via your personal Phab account - thanks!)

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Mar 23 2023, 12:42 AM

Fix NewUserMessage getContent concatenationOpen, Needs TriagePublicActions

Description

Details

Related Objects

Event Timeline

Fix NewUserMessage getContent concatenation
Open, Needs TriagePublic
Actions