Page MenuHomePhabricator

WikispeechNamespaces can't contain namspaces that aren't defined as constants
Closed, ResolvedPublic


The current implementation handles built-in namespaces, but not all namespaces introduced by other extensions, namely those that don't define a constant. To remedy this, Hooks.isValidNamespace() could be altered to also allow an int (namespace index) as parameter.

Event Timeline

Lokal_Profil moved this task from Backlog to Technical debt on the Wikispeech-WMSE board.

Also, the constants (NS_*) doesn't seem to be accessible from JS, so for T164251: Use API action to preprocess text, we need the indices.

Change 365563 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Use API to retrieve utterances

Since the namespace check was moved to front end in the patch above, the config variable was changed to use index.

Change 365563 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Use API to retrieve utterances