Page MenuHomePhabricator
Create Task
Maniphest T146454

WikispeechNamespaces can't contain namspaces that aren't defined as constants
Closed, ResolvedPublic
Actions

Description

The current implementation handles built-in namespaces, but not all namespaces introduced by other extensions, namely those that don't define a constant. To remedy this, Hooks.isValidNamespace() could be altered to also allow an int (namespace index) as parameter.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikispeechmaster+1 K -1 KUse API to retrieve utterances
Customize query in gerrit

Related Objects

Event Timeline

Sebastian_Berlin-WMSE created this task.Sep 23 2016, 9:11 AM
Sebastian_Berlin-WMSE moved this task from Incoming to Backlog on the Wikispeech board.
Sebastian_Berlin-WMSE added a project: Wikispeech-WMSE.
Lokal_Profil triaged this task as Low priority.Oct 4 2016, 12:59 PM
Lokal_Profil moved this task from Backlog to Technical debt on the Wikispeech-WMSE board.
Sebastian_Berlin-WMSE moved this task from Backlog to Incoming on the Wikispeech board.Oct 4 2016, 12:59 PM
Sebastian_Berlin-WMSE moved this task from Incoming to Backlog on the Wikispeech board.Nov 16 2016, 1:59 PM
Sebastian_Berlin-WMSE updated the task description. (Show Details)Jun 14 2017, 9:43 AM
Sebastian_Berlin-WMSE added a comment.Jun 14 2017, 10:08 AM

Also, the constants (NS_*) doesn't seem to be accessible from JS, so for T164251: Use API action to preprocess text, we need the indices.

gerritbot added a subscriber: gerritbot.Jul 17 2017, 9:20 AM

Change 365563 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Use API to retrieve utterances

https://gerrit.wikimedia.org/r/365563

gerritbot added a project: Patch-For-Review.Jul 17 2017, 9:20 AM
Sebastian_Berlin-WMSE mentioned this in rEWISc67c26b95feb: Use API to retrieve utterances.Jul 17 2017, 9:25 AM
Sebastian_Berlin-WMSE added a comment.Jul 17 2017, 9:39 AM

Since the namespace check was moved to front end in the patch above, the config variable was changed to use index.

Lokal_Profil mentioned this in rEWISfcd3d105b3b4: Use API to retrieve utterances.Jul 19 2017, 8:42 AM
Lokal_Profil mentioned this in rEWISbe65eb260df6: Use API to retrieve utterances.Aug 4 2017, 2:20 PM
Sebastian_Berlin-WMSE mentioned this in rEWIS407c1f796b44: Use API to retrieve utterances.Aug 24 2017, 2:48 PM
Sebastian_Berlin-WMSE mentioned this in rEWIS1c4575e2910b: Use API to retrieve utterances.Aug 25 2017, 7:51 AM
Sebastian_Berlin-WMSE mentioned this in rEWIS7cfd1ca70f97: Use API to retrieve utterances.Aug 25 2017, 9:19 AM
gerritbot added a comment.Aug 25 2017, 9:32 AM

Change 365563 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Use API to retrieve utterances

https://gerrit.wikimedia.org/r/365563

Stashbot mentioned this in T172094: npm 3 requires peer dependencies to be explicitly defined in package.json.Aug 25 2017, 9:59 AM
Stashbot mentioned this in T173516: Use json file extension for the stylelint config file.
Stashbot mentioned this in T164251: Use API action to preprocess text.
Stashbot added a subscriber: Stashbot.

Mentioned in SAL (#wikimedia-cloud) [2017-08-25T09:59:28Z] <Sebastian-WMSE> Deploy latest from Git master: cdedb07, 827fbb2 (T172094), 827fbb2, 2791dad, a7e5eaf, 03ca986, d84db16 (T173516), 7cfd1ca (T164251, T146454)

Sebastian_Berlin-WMSE closed this task as Resolved.Dec 4 2017, 10:15 AM
Sebastian_Berlin-WMSE claimed this task.
Diffusion mentioned this in rEWIS39199430cc9c: Update patch set 5.Jun 11 2018, 6:32 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL