Page MenuHomePhabricator

[Bug] Editing should be disabled on diffs and old revisions
Closed, ResolvedPublic

Description

The big refactoring done by Adrian introduced a regression: old revisions (diffs and so on) can be edited again.

At one point we disabled all JavaScript on old revisions. This was bad because the terms table could not be expanded then. Better solution is to make the view aware if it should be in edit or read-only mode.

The patch https://gerrit.wikimedia.org/r/304252 was originally created for T129836: References sections are not expanded anymore when viewing diffs.

Event Timeline

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptSep 23 2016, 12:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thiemowmde triaged this task as High priority.Sep 23 2016, 12:37 PM
thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-09-21 board.
thiemowmde moved this task from incoming to in progress on the Wikidata board.