Page MenuHomePhabricator

Edit conflicts should be handled intelligently
Closed, InvalidPublic

Description

Right now (without testing), it seems to me that editing an annotation after loading the page, when another user deletes an annotation, messing up the order in the JSON, would cause an edit conflict. We don't handle that right now. We should probably:

  • Try to figure out which annotation we're editing, based on location/content
  • If that fails, go to an edit conflict page or load our own edit conflict interface
  • If that fails, "stash" the annotation value and somehow ask the user to fix the conflict manually...

Obviously some conversation to be had about what the interface should look like, etc.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2016, 5:42 PM
MarkTraceur closed this task as Invalid.Feb 19 2019, 9:46 PM

Since T216565 will obviate this task, closing as invalid.