Page MenuHomePhabricator

Striker should respect TitleBlacklist bans on new account names
Closed, ResolvedPublic

Event Timeline

Based on T110751#2298602 it sounds like action=query&list=users&usprop=cancreate is the right way to check all of the various creation blocks that might be in place. That API doesn't have an equivalent of titleblacklist's tbnooverride parameter, so it seems like it should be called as an anon to ensure that the calling user's on-wiki rights don't mask something that would normally not be allowed.

h/t to @Legoktm for pointing me to this

We should add an ip block check as well. The OAuth step of account creation will check for a block on meta (or whatever wiki is used for the OAuth grant), but the requesting ip could be blocked on Wikitech separately. An ip block can be checked with action=query&list=blocks&bkip=x.x.x.x

Change 314220 had a related patch set uploaded (by BryanDavis):
Striker: Add Titleblacklist as dependency

https://gerrit.wikimedia.org/r/314220

Change 314220 merged by jenkins-bot:
Striker: Add Titleblacklist as dependency

https://gerrit.wikimedia.org/r/314220

Change 316025 had a related patch set uploaded (by BryanDavis):
Validate new usernames with action=query&list=users&usprop=cancreate

https://gerrit.wikimedia.org/r/316025

Change 316026 had a related patch set uploaded (by BryanDavis):
Check request ip for account creation blocks on Wikitech

https://gerrit.wikimedia.org/r/316026

Change 316025 merged by jenkins-bot:
Validate new usernames with action=query&list=users&usprop=cancreate

https://gerrit.wikimedia.org/r/316025

Change 316026 merged by jenkins-bot:
Check request ip for account creation blocks on Wikitech

https://gerrit.wikimedia.org/r/316026

Change 325814 had a related patch set uploaded (by BryanDavis):
Bump static, striker, and wheels submodules

https://gerrit.wikimedia.org/r/325814

Change 325814 merged by jenkins-bot:
Bump static, striker, and wheels submodules

https://gerrit.wikimedia.org/r/325814