Page MenuHomePhabricator

Don't suggest current article when adding a link in VE
Closed, ResolvedPublic1 Estimated Story Points

Description

To reproduce:

  1. Open any article for editing in VE.
  2. Click the "Add link" icon.
  3. Start typing the title of the article you're editing.

Actual result:
The current article is among the suggestions without any notice that it doesn't make sense to link it. You can select it, and it is rendered as normal link (not as bolded self-link).

Expected:
The current article should be excluded from the suggestions. There might be some rare occasions when you want to link the current page directly, but under normal circumstances it just doesn't make any sense.

Event Timeline

Esanders renamed this task from Don't suggest current articel when adding a link in VE to Don't suggest current article when adding a link in VE.Sep 30 2016, 7:18 PM

Change 313614 had a related patch set uploaded (by Esanders):
Add an option to the title widget to exclude the current page

https://gerrit.wikimedia.org/r/313614

Change 313615 had a related patch set uploaded (by Esanders):
Pass excludeCurrentPage option to TitleSearchWidget in link inspector

https://gerrit.wikimedia.org/r/313615

Change 313614 merged by jenkins-bot:
Add an option to the title widget to exclude the current page

https://gerrit.wikimedia.org/r/313614

Change 313615 merged by jenkins-bot:
Pass excludeCurrentPage option to TitleSearchWidget in link inspector

https://gerrit.wikimedia.org/r/313615

Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.