Page MenuHomePhabricator
Create Task
Maniphest T147059

Turn off Revision Slider on Special:ComparePages and Special:Diff for different pages
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Hi. The RS creates something weird when comparing different pages (try he:Special:diff/19354520/19357934, and see the url address with two NaN-s after slider opening). Btw, the wikEdDiff stops working at all.

Details

SubjectRepoBranchLines +/-
Only load when revisions are from the same titlemediawiki/extensions/RevisionSlidermaster+2 -3
Customize query in gerrit

Related Objects

Event Timeline

IKhitron created this task.Sep 30 2016, 12:24 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptSep 30 2016, 12:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore triaged this task as High priority.Oct 4 2016, 4:42 PM
Addshore moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.
Addshore subscribed.Oct 4 2016, 4:44 PM

So the RevisionSlider is not shown on SpecialPages, however Special:Diff redirects away from a special page to a regular diff page and thus the slider is still loaded here.
The titles of the two revision ids should be compared instead and only if they match the revisionslider should be loaded!

gerritbot subscribed.Oct 4 2016, 4:48 PM

Change 314033 had a related patch set uploaded (by Addshore):
Only load when revisions are from the same title

https://gerrit.wikimedia.org/r/314033

gerritbot added a project: Patch-For-Review.Oct 4 2016, 4:48 PM
Addshore claimed this task.Oct 4 2016, 4:48 PM
Addshore added a project: User-Addshore.
Addshore added a project: WMDE-QWERTY-Team-Experimental-Sprint.
Addshore set the point value for this task to 2.
Addshore moved this task from Proposed to Review on the WMDE-QWERTY-Team-Experimental-Sprint board.
Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.
Addshore mentioned this in rERSL7cd9e7b36a10: Only load when revisions are from the same title.Oct 4 2016, 4:52 PM
IKhitron renamed this task from Turn off Revision Slider on Special:ComparePages and Special/Diff for different pages to Turn off Revision Slider on Special:ComparePages and Special:Diff for different pages.Oct 5 2016, 12:04 AM
IKhitron updated the task description. (Show Details)
gerritbot added a comment.Oct 5 2016, 9:28 AM

Change 314033 merged by jenkins-bot:
Only load when revisions are from the same title

https://gerrit.wikimedia.org/r/314033

Addshore moved this task from Review to Done on the WMDE-QWERTY-Team-Experimental-Sprint board.Oct 5 2016, 10:00 AM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)).Oct 5 2016, 10:00 AM
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Oct 5 2016, 9:44 PM
Addshore closed this task as Resolved.Oct 5 2016, 10:28 PM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team-Experimental-Sprint board.Oct 25 2016, 12:23 PM
Tobi_WMDE_SW moved this task from Incoming to Done on the Revision-Slider board.Oct 28 2016, 2:00 PM
Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:47 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL